You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David H. DeWolf" <dd...@apache.org> on 2005/07/22 23:33:34 UTC
[Fwd: pluto 1.0.1 rc3 dependencies / maven]
Good point oliver. . .fyi to the rest of you that want to get around
this issue until RC4 is released.
David
-------- Original Message --------
Subject: pluto 1.0.1 rc3 dependencies / maven
Date: Fri, 22 Jul 2005 14:51:43 +0200
From: oliver goerke <ol...@doubletwin.de>
To: ddewolf@apache.org
hey david,
just saw the questions in the mail archives about
building pluto 1.0.1 rc3 from source with maven.
there are some dependencies with jars that can not
be found: pluto-descriptors-1.0.1-rc3.jar,
pluto-deploy-1.0.1-rc3.jar etc.
these jars are part of the windows binaries
bundled with tomcat. they can be found in the
webapps\pluto\WEB-INF\lib directory. just put them
in the <maven-repository>\pluto\jars directory and
the build will work.
there's no hint about this in the archives at the
moment.
greetings,
oliver goerke
Re: Questions about the pluto source code.
Posted by Zhong ZHENG <he...@gmail.com>.
Hi,
i've created two issues in the Pluto JIRA: one for the Logger (Logger is not
necessary to extend ContainerService), and the other for ObjectIDFactory and
ControllerObjectFactory (arguments passed to get factory are not logic).
http://issues.apache.org/jira/browse/PLUTO-139
http://issues.apache.org/jira/browse/PLUTO-140
I also submitted some patches to fix them. All the patches are tested (under
the current Pluto source + Tomcat 5.5.9 + JDK1.4.1) and work well. They are
ready to apply.
Regards.
ZHENG Zhong
If you submit a patch to fix these I will apply it. I may also get
> around to it myself (but maybe not as quickly). If nothing else, would
> you create a JIRA issue for these two items.
>
> Thanks!
>
> David
>
>
--
ZHENG Zhong
heavyzheng.AT.gmail.com <http://heavyzheng.AT.gmail.com>
Re: Compile error when building pluto source checked out from pluto/trunk
Posted by Craig Doremus <cr...@maine.com>.
Zhong,
Thank you. I committed this fix to SVN.
/Craig
Zhong ZHENG wrote:
>Hi, there
>
>i checked out the latest pluto source code from the trunk, and when building
>it, i got a compile error in the class:
>
>org.apache.pluto.portalImpl.core.PortalURL
>
>Line 306, method 'public String toString(PortalControlParameter
>controlParam,Boolean p_secure)'.
>control = control.replace("+", "%20");
>
>The 'replace(String, String)' method does not exist in J2SE 1.4. So i guess
>that you are using J2SE 5.0.
>In J2SE 5.0, String has a method 'replace(CharSequence, CharSequence)', and
>the String class implements the CharSequence interface.
>
>In order to be compatible with J2SE 1.4, i fixed that line as following:
>
>control = control.replaceAll("\\+", "%20");
>
>Regards.
>ZHENG Zhong
>
>
>
Re: Compile error when building pluto source checked out from pluto/trunk
Posted by Zhong ZHENG <he...@gmail.com>.
Hi,
I've created a JIRA issue for that, and provided the fixed version.
http://issues.apache.org/jira/browse/PLUTO-138
Since the fixed version has already been committed to the repository, that
issue should be closed, i think.
Regards.
ZHENG Zhong
On 7/23/05, David H. DeWolf <dd...@apache.org> wrote:
>
> This is an important fix that we need to get in before rc4! Thanks.
> Did you create a Jira issue for it?
>
> David
>
> Zhong ZHENG wrote:
> > Hi, there
> >
> > i checked out the latest pluto source code from the trunk, and when
> > building it, i got a compile error in the class:
> >
> > org.apache.pluto.portalImpl.core.PortalURL
> >
> > Line 306, method 'public String toString(PortalControlParameter
> > controlParam,Boolean p_secure)'.
> > control = control.replace("+", "%20");
> >
> > The 'replace(String, String)' method does not exist in J2SE 1.4. So i
> > guess that you are using J2SE 5.0.
> > In J2SE 5.0, String has a method 'replace(CharSequence, CharSequence)',
> > and the String class implements the CharSequence interface.
> >
> > In order to be compatible with J2SE 1.4, i fixed that line as following:
> >
> > control = control.replaceAll("\\+", "%20");
> >
> > Regards.
> > ZHENG Zhong
> > |
> >
> > |
> >
>
>
--
ZHENG Zhong
heavyzheng.AT.gmail.com <http://heavyzheng.AT.gmail.com>
Re: Compile error when building pluto source checked out from pluto/trunk
Posted by "David H. DeWolf" <dd...@apache.org>.
This is an important fix that we need to get in before rc4! Thanks.
Did you create a Jira issue for it?
David
Zhong ZHENG wrote:
> Hi, there
>
> i checked out the latest pluto source code from the trunk, and when
> building it, i got a compile error in the class:
>
> org.apache.pluto.portalImpl.core.PortalURL
>
> Line 306, method 'public String toString(PortalControlParameter
> controlParam,Boolean p_secure)'.
> control = control.replace("+", "%20");
>
> The 'replace(String, String)' method does not exist in J2SE 1.4. So i
> guess that you are using J2SE 5.0.
> In J2SE 5.0, String has a method 'replace(CharSequence, CharSequence)',
> and the String class implements the CharSequence interface.
>
> In order to be compatible with J2SE 1.4, i fixed that line as following:
>
> control = control.replaceAll("\\+", "%20");
>
> Regards.
> ZHENG Zhong
> |
>
> |
>
Compile error when building pluto source checked out from pluto/trunk
Posted by Zhong ZHENG <he...@gmail.com>.
Hi, there
i checked out the latest pluto source code from the trunk, and when building
it, i got a compile error in the class:
org.apache.pluto.portalImpl.core.PortalURL
Line 306, method 'public String toString(PortalControlParameter
controlParam,Boolean p_secure)'.
control = control.replace("+", "%20");
The 'replace(String, String)' method does not exist in J2SE 1.4. So i guess
that you are using J2SE 5.0.
In J2SE 5.0, String has a method 'replace(CharSequence, CharSequence)', and
the String class implements the CharSequence interface.
In order to be compatible with J2SE 1.4, i fixed that line as following:
control = control.replaceAll("\\+", "%20");
Regards.
ZHENG Zhong
Re: Questions about the pluto source code.
Posted by "David H. DeWolf" <dd...@apache.org>.
See below:
Zhong ZHENG wrote:
> Hi pluto developers,
>
> i am reading the pluto source code, and here are some questions.
>
> 1, Container service interfaces are defined in the SPI. According to the
> doc, LogService is mendatory. The goal of the LogService is to create
> Logger instances for components, and i found that the Logger interface
> extends ContainerService too. That structure seems a little strange to
> me. I commented the "extends ContainerService" in the Logger class and
> rebuild pluto, and everything goes on well. So, is it necessary that
> Logger must extends ContainerService?
>
The LogService itself extends ContainerService. As a result, when you
remove the explicit implementation of ContainerService, the LogService
implementation still implements the marker interface. I'm not sure what
the original intent of this marker interface was, but you're right, I
don't think there's any technical reason why it must utilize this
appraoch (i.e., there's no code that utilizes the marker interface).
> 2, The pluto container defines a set of Factory interfaces to create
> certain classes, such as classes in the "javax.portlet" package. In the
> FactoryManagerService interface, the following method is defined:
>
> public Factory getFactory(Class theClass);
>
> The method signature seems to mean that: get a factory instance that i
> can use to create the specified class (theClass). For example, pluto
> will call FactoryManagerService.getFactory(RenderRequest.class) to get a
> render request factory instance which may be used to create
> RenderRequest instances. But...
>
> 2.1 In the "org.apache.pluto.util.ObjectIDAccess" class, pluto calls
> FactoryManagerService.getFactory(ObjectIDFactory.class) to get an
> ObjectIDFactory instance, which may be used to create ObjectID
> instances. Is it more logical to get the ObjectIDFactory by calling
> FactoryManagerService.getFactory(ObjectID.class)?
>
Yes, it would. I agree.
> 2.2 In the "org.apache.pluto.om.ControllerObjectAccess" class, pluto
> calls FactoryManagerService.getFactory(ControllerFactory.class) to get a
> ControllerFactory instance, which may be used to create Controller
> instances. Is it more logical to get the ControllerFactory by calling
> FactoryManagerService.getFactory(Controller.class)?
>
Yes, it would, I agree again.
If you submit a patch to fix these I will apply it. I may also get
around to it myself (but maybe not as quickly). If nothing else, would
you create a JIRA issue for these two items.
Thanks!
David
> Thanks in advance for your reply.
>
> Regards
>
Questions about the pluto source code.
Posted by Zhong ZHENG <he...@gmail.com>.
Hi pluto developers,
i am reading the pluto source code, and here are some questions.
1, Container service interfaces are defined in the SPI. According to the
doc, LogService is mendatory. The goal of the LogService is to create Logger
instances for components, and i found that the Logger interface extends
ContainerService too. That structure seems a little strange to me. I
commented the "extends ContainerService" in the Logger class and rebuild
pluto, and everything goes on well. So, is it necessary that Logger must
extends ContainerService?
2, The pluto container defines a set of Factory interfaces to create certain
classes, such as classes in the "javax.portlet" package. In the
FactoryManagerService interface, the following method is defined:
public Factory getFactory(Class theClass);
The method signature seems to mean that: get a factory instance that i can
use to create the specified class (theClass). For example, pluto will call
FactoryManagerService.getFactory(RenderRequest.class) to get a render
request factory instance which may be used to create RenderRequest
instances. But...
2.1 In the "org.apache.pluto.util.ObjectIDAccess" class, pluto calls
FactoryManagerService.getFactory(ObjectIDFactory.class) to get an
ObjectIDFactory instance, which may be used to create ObjectID instances. Is
it more logical to get the ObjectIDFactory by calling
FactoryManagerService.getFactory(ObjectID.class)?
2.2 In the "org.apache.pluto.om.ControllerObjectAccess" class, pluto calls
FactoryManagerService.getFactory(ControllerFactory.class) to get a
ControllerFactory instance, which may be used to create Controller
instances. Is it more logical to get the ControllerFactory by calling
FactoryManagerService.getFactory(Controller.class)?
Thanks in advance for your reply.
Regards
Re: [Fwd: pluto 1.0.1 rc3 dependencies / maven]
Posted by Ulrich Küster <Ul...@uni-jena.de>.
> there are some dependencies with jars that can not
> be found: pluto-descriptors-1.0.1-rc3.jar,
> pluto-deploy-1.0.1-rc3.jar etc.
With the current rc4 source code from the SVN-Repository I get the same
unsatisfied dependencies for
pluto-descriptors-1.0.1-rc4.jar, pluto-deploy-1.0.1-rc4.jar, etc.
I checked out the source code and ran maven -fullDeployment on it.
What am I doing wrong? What do I have to do in order to get them created
by maven in my maven repository when running a fullDeployment goal?
Ulrich