You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/29 23:04:41 UTC
[GitHub] [bookkeeper] rdhabalia opened a new pull request #2258:
[code-style] fix build failure for check-style
rdhabalia opened a new pull request #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258
Descriptions of the changes in this PR:
### Motivation
PR Validation build is failing with below exception:
```
[ERROR] src/main/java/org/apache/bookkeeper/stream/storage/impl/cluster/ZkClusterInitializer.java:[35] (imports) ImportOrder: Import org.apache.bookkeeper.stream.storage.StorageConstants.getSegmentsRootPath appears after other imports that it should precede
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default-cli) on project stream-storage-service-impl: You have 1 Checkstyle violation. -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia removed a comment on issue #2258:
[code-style] fix build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia removed a comment on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580388633
rerun integration tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580537409
+ @sijie
@eolivelli that button doesn't show up for non-committers. so, it seems there is no way to trigger the job if one is not committer.
PR-validation build is passing in this PR. so, can you please help to trigger the job and merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580129343
@rdhabalia let's wait for CI.
Please ping me if you do not ear news.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580713326
ignore ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580393091
also, do you know what comment I can use to trigger failed build.? Earlier it was showing the text next to job eg: `run integration test` but not anymore so, I can not trigger the failed job and have to depend on one of the committer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli merged pull request #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580388633
rerun integration tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580005087
I think all the failing PRs need to be rebased or we can remove stream project from check-style validation for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580388995
I am not able to re-trigger failed integration tests. Can you please retrigger it and merge this PR so, we can merge other PRs as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] rdhabalia edited a comment on issue #2258:
[code-style] fix build failure for check-style
Posted by GitBox <gi...@apache.org>.
rdhabalia edited a comment on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580537409
+@sijie
@eolivelli that button doesn't show up for non-committers. so, it seems there is no way to trigger the job if one is not committer.
PR-validation build is passing in this PR. so, can you please help to trigger the job and merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580129051
@rdhabalia I had already noticed this problem and I am also fixing it here:
https://github.com/apache/bookkeeper/pull/2233/files#diff-59c5d2e1e027b204475a58b0dac71c68R22
I am going to commit your fix iImmediately.
Thank you.
I don't understand why this problem started to occour.
We are always committing only changes that pass validation
Do you have any idea ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2258: [code-style] fix
build failure for check-style
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2258: [code-style] fix build failure for check-style
URL: https://github.com/apache/bookkeeper/pull/2258#issuecomment-580492608
You have to click on the link and open github actions page. Then you can find a re-run checks button on the right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services