[GitHub] [curator] kezhuw commented on pull request #446: CURATOR-518: Fix LeaderSelector requeue broken by interruptLeadership

["kezhuw (via GitHub)" <gi...@apache.org>]

kezhuw commented on PR #446:
URL: https://github.com/apache/curator/pull/446#issuecomment-1454774272

   [CURATOR-518](https://issues.apache.org/jira/browse/CURATOR-518) covers two things I think:
   1. `interruptLeadership` did not test `hasLeadership` as what its javadoc says "if this instance has leadership".
   2. `interruptLeadership` could break `autoRequeue`.
   
   There are different since `interruptLeadership` has two different usages:
   1. Public API: we should either change its javadoc or its implementation.
   2. Cancel election regardless of leadership in case of session state change. Currently, auto-requeue is done by submit next election in its own task. But `FutureTask.cancel` chould cancel election task before it got a chance to run. Apparently, this is a bug in implementation.
   
   Any thoughts ? @eolivelli @tisonkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org