You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2021/07/19 14:34:15 UTC

[GitHub] [storm] Ethanlm edited a comment on pull request #3366: [STORM-3388] Launch workers inside container using runc runtime

Ethanlm edited a comment on pull request #3366:
URL: https://github.com/apache/storm/pull/3366#issuecomment-882596986


   Addressed most of the comments, except 
   1) add more comments in docker-to-squash.py.
   2) add error messages in c code where it is missing
   3) 4 unanswered questions about oci c code
     https://github.com/apache/storm/pull/3366#discussion_r550554308
     https://github.com/apache/storm/pull/3366#discussion_r550557309
     https://github.com/apache/storm/pull/3366#discussion_r549507997
     https://github.com/apache/storm/pull/3366#discussion_r549506181
   
   
   Will address these as follow-ups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org