You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2010/12/09 00:20:01 UTC
[jira] Created: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
A more elegant FileSystem#listCorruptFileBlocks API
---------------------------------------------------
Key: HADOOP-7060
URL: https://issues.apache.org/jira/browse/HADOOP-7060
Project: Hadoop Common
Issue Type: Bug
Reporter: Hairong Kuang
Assignee: Patrick Kling
I'd like to change the newly added listCorruptFileBlocks signature to be:
{code}
/**
* Get all files with corrupt blocks under the given path
*/
RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
{code}
This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970133#action_12970133 ]
Hudson commented on HADOOP-7060:
--------------------------------
Integrated in Hadoop-Common-trunk #541 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/541/])
HADOOP-7060 Remove the unused files from the repository
HADOOP-7060. A more elegant FileSystem#listCorruptFileBlocks API. Contributed by Patrick Kling.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Fix For: 0.23.0
>
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7060:
----------------------------------
Status: Patch Available (was: Open)
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969970#action_12969970 ]
Hairong Kuang commented on HADOOP-7060:
---------------------------------------
Thanks, Patrick!
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Fix For: 0.23.0
>
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-7060:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Fix For: 0.23.0
>
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-7060:
----------------------------------
Component/s: fs
Affects Version/s: 0.23.0
Issue Type: Improvement (was: Bug)
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Fix For: 0.23.0
>
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969961#action_12969961 ]
Hairong Kuang commented on HADOOP-7060:
---------------------------------------
+1. This looks good to me.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969624#action_12969624 ]
Hadoop QA commented on HADOOP-7060:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12465880/HADOOP-7060.patch
against trunk revision 1043117.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/136//console
This message is automatically generated.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969989#action_12969989 ]
Hudson commented on HADOOP-7060:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #454 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/454/])
HADOOP-7060 Remove the unused files from the repository
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Fix For: 0.23.0
>
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969873#action_12969873 ]
Hairong Kuang commented on HADOOP-7060:
---------------------------------------
Please remove class CorruptFileBlocks. We need to move it to HDFS.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7060:
----------------------------------
Attachment: HADOOP-7060.patch
ant test passes.
ant test-patch results:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
{code}
A test for this change is included in HDFS-1533 (TestListCorruptFileBlocks).
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969905#action_12969905 ]
Patrick Kling commented on HADOOP-7060:
---------------------------------------
Actually, ant test-patch is +1 overall now since deleting a test counts as modifying it...
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969909#action_12969909 ]
Hadoop QA commented on HADOOP-7060:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12465934/HADOOP-7060.2.patch
against trunk revision 1043117.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/138//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/138//console
This message is automatically generated.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7060) A more elegant
FileSystem#listCorruptFileBlocks API
Posted by "Patrick Kling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Kling updated HADOOP-7060:
----------------------------------
Attachment: HADOOP-7060.2.patch
Moved CorruptFileBlocks (and TestCorruptFileBlocks) to HDFS.
Test/test-patch results are unchanged.
> A more elegant FileSystem#listCorruptFileBlocks API
> ---------------------------------------------------
>
> Key: HADOOP-7060
> URL: https://issues.apache.org/jira/browse/HADOOP-7060
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Hairong Kuang
> Assignee: Patrick Kling
> Attachments: HADOOP-7060.2.patch, HADOOP-7060.patch
>
>
> I'd like to change the newly added listCorruptFileBlocks signature to be:
> {code}
> /**
> * Get all files with corrupt blocks under the given path
> */
> RemoteIterator<Path> listCorruptFileBlocks(Path src) throws IOException;
> {code}
> This new API does not expose "cookie" to user although underlying implementation may still need to invoke multiple RPCs to get the whole list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.