You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/30 09:07:52 UTC
[GitHub] [tvm] alter-xp opened a new pull request #7771: add onnx reverse sequence op
alter-xp opened a new pull request #7771:
URL: https://github.com/apache/tvm/pull/7771
add onnx reverse sequence op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-822581726
It looks like somehow to test is failing on GPU. Is that something you can debug? If you don't have access to a machine with an nvidia GPU, I can take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #7771:
URL: https://github.com/apache/tvm/pull/7771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-831339386
@alter-xp Pinging again. This op is cropping into my view on a model, so I'd like to get this merged. I'm also interested in seeing these tests enabled as part of this PR:
https://github.com/apache/tvm/blob/cea7cf16ce867bb39ff40376f3f25cd2df67c431/tests/python/frontend/onnx/test_forward.py#L4227-L4228
Is this something you can get back to?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-819076236
@alter-xp Thanks for the contribution! Can you rebase to fix the merge conflict and fix lint? It looks great from a quick pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-836880714
Thanks @alter-xp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
alter-xp commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-835262405
@mbrookhart OMG, I haven't paid attention to this PR during this time. Let me see what causes the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] alter-xp commented on pull request #7771: add onnx reverse sequence op
Posted by GitBox <gi...@apache.org>.
alter-xp commented on pull request #7771:
URL: https://github.com/apache/tvm/pull/7771#issuecomment-836100862
> https://github.com/apache/tvm/blob/cea7cf16ce867bb39ff40376f3f25cd2df67c431/tests/python/frontend/onnx/test_forward.py#L4227-L4228
My tests include them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org