[GitHub] [incubator-devlake] rulerhuang opened a new issue, #2127: [Bug] [icla plugin] "make dev" complie error

[GitBox <gi...@apache.org>]

rulerhuang opened a new issue, #2127:
URL: https://github.com/apache/incubator-devlake/issues/2127

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   when i execute make dev, catch a compile error:
   
   # make dev
   Building plugin ae to bin/plugins/ae/ae.so
   Building plugin dbt to bin/plugins/dbt/dbt.so
   Building plugin feishu to bin/plugins/feishu/feishu.so
   Building plugin gitextractor to bin/plugins/gitextractor/gitextractor.so
   Building plugin github to bin/plugins/github/github.so
   Building plugin gitlab to bin/plugins/gitlab/gitlab.so
   Building plugin icla to bin/plugins/icla/icla.so
   # command-line-arguments
   plugins/icla/plugin_main.go:98:56: too many arguments in call to runner.DirectRun
   	have (*cobra.Command, []string, Icla, []string, map[string]interface{})
   	want (*cobra.Command, []string, core.PluginTask, map[string]interface{})
   make: *** [Makefile:25: build-plugin] Error 2
   
   
   ### What you expected to happen
   
   compile succeed, and run "go run main.go" to start application.
   
   ### How to reproduce
   
   use main branch , commit id is 0d3aa41e5e3db60e7ddfd3c3835f40e8c1c8eeb4. then execute "make dev" command
   
   ### Anything else
   
   check source code  plugins/icla/plugin_main.go, find the wrong code:
   `golang
    89 // standalone mode for debugging
    90 func main() {
    91     cmd := &cobra.Command{Use: "icla"}
    92 
    93     // TODO add your cmd flag if necessary
    94     // yourFlag := cmd.Flags().IntP("yourFlag", "y", 8, "TODO add description here")
    95     // _ = cmd.MarkFlagRequired("yourFlag")
    96 
    97     cmd.Run = func(cmd *cobra.Command, args []string) {
    98         runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}{              // Wrong code                                                                                      
   100             // TODO add more custom params here
   101         })
   102     }
   103  
   `
   change  "runner.DirectRun(cmd, args, PluginEntry, []string{}, map[string]interface{}"  to "runner.DirectRun(cmd, args, PluginEntry, map[string]interface{}" will work.
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh closed issue #2127: [Bug] [icla plugin] "make dev" complie error

[GitBox <gi...@apache.org>]

klesh closed issue #2127: [Bug] [icla plugin] "make dev" complie error 
URL: https://github.com/apache/incubator-devlake/issues/2127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org