[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6289: Rename segmentPushType and SegmentPushFrequency to segmentLoadType and segmentLoadFrequency

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #6289:
URL: https://github.com/apache/incubator-pinot/pull/6289#discussion_r530550913



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/BatchIngestionConfig.java
##########
@@ -35,31 +35,31 @@
   @JsonPropertyDescription("Configs for all the batch sources to ingest from")
   private final List<Map<String, String>> _batchConfigMaps;
 
-  @JsonPropertyDescription("Push type APPEND or REFRESH")
-  private final String _segmentPushType;
+  @JsonPropertyDescription("Load type APPEND or REFRESH")
+  private final String _segmentLoadType;
 
-  @JsonPropertyDescription("Push frequency HOURLY or DAILY")
-  private final String _segmentPushFrequency;
+  @JsonPropertyDescription("Load frequency HOURLY or DAILY")
+  private final String _segmentLoadFrequency;
 
   @JsonCreator
   public BatchIngestionConfig(@JsonProperty("batchConfigMaps") @Nullable List<Map<String, String>> batchConfigMaps,
-      @JsonProperty("segmentPushType") String segmentPushType,
-      @JsonProperty("segmentPushFrequency") String segmentPushFrequency) {
+      @JsonProperty("segmentLoadType") String segmentLoadType,
+      @JsonProperty("segmentLoadFrequency") String segmentLoadFrequency) {

Review comment:
       make sense, i will make the change
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org