You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/25 05:22:03 UTC

[GitHub] [incubator-seatunnel] LinZhaoguan opened a new pull request, #2523: [Bug][Core] Let the SparkCommandArgs do not split the variable value with comma

LinZhaoguan opened a new pull request, #2523:
URL: https://github.com/apache/incubator-seatunnel/pull/2523

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This pull request optimized the parsing rules for custom command line variables, users can pass the variable value with comma, and variable values will not be divided by comma
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2523: [Bug][Core] Let the SparkCommandArgs do not split the variable value with comma

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2523:
URL: https://github.com/apache/incubator-seatunnel/pull/2523#issuecomment-1226804759

   By the way, the code style need be fixed. You can use checkstyle file in `tools/checkstyle` to make sure your code meet the requirements


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] LinZhaoguan commented on pull request #2523: [Bug][Core] Let the SparkCommandArgs do not split the variable value with comma

Posted by GitBox <gi...@apache.org>.
LinZhaoguan commented on PR #2523:
URL: https://github.com/apache/incubator-seatunnel/pull/2523#issuecomment-1226908334

   > By the way, the code style need be fixed. You can use checkstyle file in `tools/checkstyle` to make sure your code meet the requirements
   
   I have finished the modification, please review the code again.Thanks a lot. @Hisoka-X 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #2523: [Bug][Core] Let the SparkCommandArgs do not split the variable value with comma

Posted by GitBox <gi...@apache.org>.
Hisoka-X merged PR #2523:
URL: https://github.com/apache/incubator-seatunnel/pull/2523


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org