You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kousuke Saruta (Code Review)" <ge...@cloudera.org> on 2016/12/16 05:05:34 UTC
[kudu-CR] Remove Schema#toString from RowResult#toString
Kousuke Saruta has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5534
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Remove Schema#toString from RowResult#toString
In RowResult#toString, the result string is consists of some strings including
the result of Schema#toString but Schema doesn't explicitly declare the method
so we should remove it.
Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/5534/1
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Remove Schema#toString from RowResult#toString
In RowResult#toString, the result string is consists of some strings including
the result of Schema#toString but Schema doesn't explicitly declare the method
so we should remove it.
Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Reviewed-on: http://gerrit.cloudera.org:8080/5534
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has posted comments on this change.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Patch Set 1:
(1 comment)
Thanks for the comment.
At first, I tried to add the row data but is it already done by toStringLongFormat right?
If it's better to add it to toString too, I'll fix it.
http://gerrit.cloudera.org:8080/#/c/5534/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
Line 510: return "RowResult index: " + this.index + ", size: " + this.rowSize;
> makes sense, though I wonder if we should replace this entirely with a stri
Thanks for the comment.
At first, I tried to add the row data but is it already done by toStringLongFormat right?
If it's better to add it to toString too, I'll fix it.
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Kousuke Saruta (Code Review)" <ge...@cloudera.org>.
Kousuke Saruta has posted comments on this change.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Patch Set 1:
No problem. Thank you for taking a look at this :)
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Patch Set 1:
Dan/JD - what do you guys think about this? (sorry Kousuke for the slow response to this! lost track over the holidays)
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Patch Set 1: Code-Review+2
I'm wondering if we had a Schema#toString implementation in the past... anyways, it's not there now!
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove Schema#toString from RowResult#toString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Remove Schema#toString from RowResult#toString
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5534/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
Line 510: return "RowResult index: " + this.index + ", size: " + this.rowSize;
makes sense, though I wonder if we should replace this entirely with a stringification that actually contains the row data?
--
To view, visit http://gerrit.cloudera.org:8080/5534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e01cc1cc52958c73dfd75304a826ea033ce785
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes