[jira] [Commented] (IGNITE-1355) Potential NPE in CacheAffinityProxy

["Semen Boikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050260#comment-15050260 ] 

Semen Boikov commented on IGNITE-1355:
--------------------------------------

Changes look good, but I see minor issues in GridAffinityProcessor:
- line 894: '@Nullable private AffinityInfo cache() throws IgniteCheckedException {' - please remove '@Nullable' here
- line 895: unnesessary call 'ctx.discovery().topologyVersionEx();', please remove

> Potential NPE in CacheAffinityProxy
> -----------------------------------
>
>                 Key: IGNITE-1355
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1355
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: ignite-1.4
>            Reporter: Semen Boikov
>            Assignee: Artem Shutak
>            Priority: Critical
>             Fix For: 1.6
>
>
> NPE was observed on TC:
> {noformat}
> java.lang.NullPointerException
>     at org.apache.ignite.internal.processors.affinity.GridAffinityProcessor$AffinityInfo.access$1800(GridAffinityProcessor.java:537)
>     at org.apache.ignite.internal.processors.affinity.GridAffinityProcessor$CacheAffinityProxy.mapPartitionToPrimaryAndBackups(GridAffinityProcessor.java:879)
>     at org.apache.ignite.testframework.junits.common.GridCommonAbstractTest.awaitPartitionMapExchange(GridCommonAbstractTest.java:423)
>     at org.apache.ignite.internal.processors.cache.distributed.dht.IgniteCacheCrossCacheTxFailoverTest.crossCacheTxFailover(IgniteCacheCrossCacheTxFailoverTest.java:355)
> {noformat}
> As I see method CacheAffinityProxy.cache() can return null, but there are no checks for null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)