[jira] Updated: (HADOOP-5258) Provide dfsadmin functionality to report on namenode's view of network topology

["Jakob Homan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated HADOOP-5258:
--------------------------------

    Attachment: HADOOP-5258.patch

bq. StringUtils.getHostNameOfIP() should be a part of NetUtil rather than StringUtil.
Done. I had originally placed it in StringUtil because getHostName(), a similar method, was in StringUtil, but that method should also be in NetUtil.  I've moved getHostName() to NetUtil, and updated the references to it.
bq. See org.apache.hadoop.net.NetUtils.normalizeHostName(String), which is similar to your method.
Actually, normalizeHostName(String) does the opposite of my method.  It goes (hostname|IP) -> IP, mine goes IP -> hostname.
bq. In DFSAdmin.printTopology() use ArrayList instead of Vector. Vector is synchronized, which is not necessary here.
Correct.  The next item resolves this.
bq. Instead of explicitly sorting the data-nodes within the rack you could just insert them into the list in the right order, using Collections.binarySearch() and then List.add(int index, E element)
I've replaced the ArrayList with a TreeSet, which resolves the issue and is more efficient than an ArrayList and cleaner than a binarySearch method.  
bq. In DFSAdmin.printHelp() you should add printing printTopology in case cmd is not equal to any known command. In the very last else case.
Done.
bq. DatanodeInfo.getNetworkLocation() could you please remove last * in the JavaDoc comment. Should be /** rack name */
Done.

> Provide dfsadmin functionality to report on namenode's view of network topology
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-5258
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5258
>             Project: Hadoop Core
>          Issue Type: New Feature
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HADOOP-5258.patch, HADOOP-5258.patch, HADOOP-5258.patch
>
>
> As discussed in HADOOP-4954, it would be useful to be able to query the namenode to its current view on the network topology of racks and datanodes.  This would allow ops to compare what the namenode sees with what they expect it to see.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.