You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by ac...@apache.org on 2020/05/03 18:58:03 UTC

[incubator-nuttx] 07/07: arch/arm/src/stm32/stm32_adc.c: remove obsolete warnings

This is an automated email from the ASF dual-hosted git repository.

acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit f03ed73f91676933d56d699b68228e93ca63ba22
Author: raiden00pl <ra...@railab.me>
AuthorDate: Sun May 3 15:03:30 2020 +0200

    arch/arm/src/stm32/stm32_adc.c: remove obsolete warnings
---
 arch/arm/src/stm32/stm32_adc.c | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/arch/arm/src/stm32/stm32_adc.c b/arch/arm/src/stm32/stm32_adc.c
index a19ba37..b9f615f 100644
--- a/arch/arm/src/stm32/stm32_adc.c
+++ b/arch/arm/src/stm32/stm32_adc.c
@@ -98,28 +98,14 @@
 #  error "STM32 ADC IP version not specified"
 #endif
 
-/* At this moment only support for the STM32 ADC IPv2 looks fully functional:
- *   - noDMA
- *   - DMA
- *   - TIM trg
- *   - TIM trg + DMA
- *
- * Support for the STM32 ADC IPv1 works fine only for:
- *   - noDMA (but only with 1 sample)
- *   - TIM trg
- *   - TIM trg + DMA
+/* Supported ADC modes:
+ *   - SW triggering with/without DMA transfer
+ *   - TIM triggering with/without DMA tranfer
+ *   - external triggering with/without DMA transfer
  *
  * (tested with ADC example app from Nuttx apps repo).
  */
 
-#ifdef HAVE_IP_ADC_V1
-#  if defined(ADC_HAVE_DMA) && !defined(ADC_HAVE_TIMER)
-#    warning "ADC DMA mode without hardware trigger may not work properly!"
-#  elif !defined(ADC_HAVE_DMA) && !defined(ADC_HAVE_TIMER)
-#    warning "ADC without hardware trigger and without DMA may not work properly!"
-#  endif
-#endif
-
 /* At the moment there is no proper implementation for timers external
  * trigger in STM32L15XX may be added later
  */