You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/04/16 09:58:14 UTC

[royale-asjs] branch develop updated: core-keyboardevent: support "ArrowDown", "ArrowUp" and "Enter"

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 76ff248  core-keyboardevent: support "ArrowDown", "ArrowUp" and "Enter"
76ff248 is described below

commit 76ff248971d035712cf768966881df796ebebf88
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Apr 16 11:58:08 2020 +0200

    core-keyboardevent: support "ArrowDown", "ArrowUp" and "Enter"
---
 .../main/royale/org/apache/royale/events/KeyboardEvent.as   | 13 ++++++++-----
 .../royale/jewel/supportClasses/textinput/TextInputBase.as  |  2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/events/KeyboardEvent.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/events/KeyboardEvent.as
index 4fa0f51..623bb83 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/events/KeyboardEvent.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/events/KeyboardEvent.as
@@ -20,13 +20,12 @@ package org.apache.royale.events
 {
     COMPILE::JS
     {
-        import goog.events.BrowserEvent;
-        import org.apache.royale.core.ElementWrapper;
-		import org.apache.royale.events.Event;
-        import org.apache.royale.events.utils.KeyboardEventConverter;
+    import goog.events.BrowserEvent;
+    import org.apache.royale.core.ElementWrapper;
+    import org.apache.royale.events.Event;
+    import org.apache.royale.events.utils.KeyboardEventConverter;
     }
     import org.apache.royale.events.IBrowserEvent;
-    import org.apache.royale.utils.OSUtils;
 
     /**
      *  Keyboard events
@@ -50,6 +49,10 @@ package org.apache.royale.events
         COMPILE::JS
         public static const KEY_UP:String = "keyup";
 
+        public static const KEYCODE__UP:String = "ArrowUp";
+        public static const KEYCODE__DOWN:String = "ArrowDown";
+        public static const KEYCODE__ENTER:String = "Enter";
+
         public static const KEYCODE_UP:uint = 38;
         public static const KEYCODE_DOWN:uint = 40;
         public static const KEYCODE_LEFT:uint = 37;
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
index 1c1c77e..ad60765 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
@@ -195,7 +195,7 @@ package org.apache.royale.jewel.supportClasses.textinput
         {
             COMPILE::JS
             {
-            if (event['key'] === 'Enter') {
+            if (event.key === KeyboardEvent.KEYCODE__ENTER) {
                 // Cancel the default action, if needed
                 event.preventDefault();
                 dispatchEvent(new Event("enter"));