You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:37:12 UTC
[GitHub] [kafka] see-quick commented on a diff in pull request #12689: MINOR: Improve unit test coverage of LeaderAndIsr class
see-quick commented on code in PR #12689:
URL: https://github.com/apache/kafka/pull/12689#discussion_r981009538
##########
core/src/test/scala/kafka/api/LeaderAndIsrTest.scala:
##########
@@ -31,4 +31,56 @@ final class LeaderAndIsrTest {
assertEquals(List(3), recoveringLeaderAndIsr.isr)
assertEquals(LeaderRecoveryState.RECOVERING, recoveringLeaderAndIsr.leaderRecoveryState)
}
+
+ @Test
+ def testNewLeaderAndIsr(): Unit = {
+ val leaderAndIsr = LeaderAndIsr(1, List(1, 2))
+ val newLeaderAndIsr = leaderAndIsr.newLeaderAndIsr(2, List(1, 2))
+
+ assertEquals(2, newLeaderAndIsr.leader)
+ assertEquals(List(1, 2), newLeaderAndIsr.isr)
+ assertEquals(LeaderRecoveryState.RECOVERED, newLeaderAndIsr.leaderRecoveryState)
+ }
+
+ @Test
+ def testNewLeader(): Unit = {
+ val leaderAndIsr = LeaderAndIsr(2, List(1, 2, 3))
+
+ assertEquals(2, leaderAndIsr.leader)
+ assertEquals(List(1, 2, 3), leaderAndIsr.isr)
+
+ val newLeaderAndIsr = leaderAndIsr.newLeader(3)
+
+ assertEquals(3, newLeaderAndIsr.leader)
+ assertEquals(List(1, 2, 3), newLeaderAndIsr.isr)
+ }
+
+ @Test
+ def testNewEpoch() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(3, List(1, 2, 3))
+
+ assertEquals(0, leaderAndIsr.leaderEpoch)
+
+ val leaderWithNewEpoch = leaderAndIsr.newEpoch
+
+ assertEquals(1, leaderWithNewEpoch.leaderEpoch)
+ }
+
+ @Test
+ def testLeaderOpt() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(2, List(1, 2, 3))
+
+ assertEquals(2, leaderAndIsr.leaderOpt.get)
+ }
+
+ @Test
+ def testWithZkVersion() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(3, List(1, 2, 3))
+
+ assertEquals(0, leaderAndIsr.zkVersion)
Review Comment:
Yes, I have removed such a test case. It should be okay now.
##########
core/src/test/scala/kafka/api/LeaderAndIsrTest.scala:
##########
@@ -31,4 +31,56 @@ final class LeaderAndIsrTest {
assertEquals(List(3), recoveringLeaderAndIsr.isr)
assertEquals(LeaderRecoveryState.RECOVERING, recoveringLeaderAndIsr.leaderRecoveryState)
}
+
+ @Test
+ def testNewLeaderAndIsr(): Unit = {
+ val leaderAndIsr = LeaderAndIsr(1, List(1, 2))
+ val newLeaderAndIsr = leaderAndIsr.newLeaderAndIsr(2, List(1, 2))
+
+ assertEquals(2, newLeaderAndIsr.leader)
+ assertEquals(List(1, 2), newLeaderAndIsr.isr)
+ assertEquals(LeaderRecoveryState.RECOVERED, newLeaderAndIsr.leaderRecoveryState)
+ }
+
+ @Test
+ def testNewLeader(): Unit = {
+ val leaderAndIsr = LeaderAndIsr(2, List(1, 2, 3))
+
+ assertEquals(2, leaderAndIsr.leader)
+ assertEquals(List(1, 2, 3), leaderAndIsr.isr)
+
+ val newLeaderAndIsr = leaderAndIsr.newLeader(3)
+
+ assertEquals(3, newLeaderAndIsr.leader)
+ assertEquals(List(1, 2, 3), newLeaderAndIsr.isr)
+ }
+
+ @Test
+ def testNewEpoch() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(3, List(1, 2, 3))
+
+ assertEquals(0, leaderAndIsr.leaderEpoch)
+
+ val leaderWithNewEpoch = leaderAndIsr.newEpoch
+
+ assertEquals(1, leaderWithNewEpoch.leaderEpoch)
+ }
+
+ @Test
+ def testLeaderOpt() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(2, List(1, 2, 3))
+
+ assertEquals(2, leaderAndIsr.leaderOpt.get)
+ }
+
+ @Test
+ def testWithZkVersion() : Unit = {
+ val leaderAndIsr = LeaderAndIsr(3, List(1, 2, 3))
+
+ assertEquals(0, leaderAndIsr.zkVersion)
Review Comment:
Thanks @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org