You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/09 06:05:11 UTC
[GitHub] [iceberg] simonsssu opened a new issue #1567: remove guava minimize option in ceberg-bundled-guava
simonsssu opened a new issue #1567:
URL: https://github.com/apache/iceberg/issues/1567
Currently we have minimize() option in ceberg-bundled-guava, which only include minimal classes in Guava, when we want to use TreeBasedTable, HashBasedTable or some other classes in guava, we should include other guava dependency, which may easily cause class conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #1567: remove guava minimize option in iceberg-bundled-guava
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #1567:
URL: https://github.com/apache/iceberg/issues/1567#issuecomment-706608984
@simonsssu, if we want additional Guava classes, then we add them to [`GuavaClasses`](https://github.com/apache/iceberg/blob/425b10cea34eef11cca9cf0d237e02274f6dc958/bundled-guava/src/main/java/org/apache/iceberg/GuavaClasses.java) so that they aren't removed when the Jar is minimized.
Also, we are trying to avoid depending more on Guava because it causes so many runtime issues.
I think that the current build is a reasonable way to go, but maybe I've misunderstood your concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on issue #1567: remove guava minimize option in iceberg-bundled-guava
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #1567:
URL: https://github.com/apache/iceberg/issues/1567#issuecomment-706236505
I'm confused why we want to do this? Isn't the point that an end user should include their own un-shaded version of guava if they want to access other classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] simonsssu commented on issue #1567: remove guava minimize option in iceberg-bundled-guava
Posted by GitBox <gi...@apache.org>.
simonsssu commented on issue #1567:
URL: https://github.com/apache/iceberg/issues/1567#issuecomment-706845748
@rdblue Hi Ryan, thanks for pointing out to use GuavaClasses, I've misunderstood what bundled-guava does. I will close the related pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] simonsssu closed issue #1567: remove guava minimize option in iceberg-bundled-guava
Posted by GitBox <gi...@apache.org>.
simonsssu closed issue #1567:
URL: https://github.com/apache/iceberg/issues/1567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org