You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/11 20:45:39 UTC
Review Request 24569: Added missing 'defer' helpers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-1692
https://issues.apache.org/jira/browse/MESOS-1692
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048
Diff: https://reviews.apache.org/r/24569/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24569: Added missing 'defer' helpers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/#review50260
-----------------------------------------------------------
Ship it!
LGTM!
3rdparty/libprocess/include/process/defer.hpp
<https://reviews.apache.org/r/24569/#comment87948>
s/set/associate/
- Jie Yu
On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24569/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1692
> https://issues.apache.org/jira/browse/MESOS-1692
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
> 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048
>
> Diff: https://reviews.apache.org/r/24569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24569: Added missing 'defer' helpers.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 12, 2014, 3:15 a.m., Vinod Kone wrote:
> > ben, can you commit this?
Committed!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/#review50282
-----------------------------------------------------------
On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24569/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1692
> https://issues.apache.org/jira/browse/MESOS-1692
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
> 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048
>
> Diff: https://reviews.apache.org/r/24569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24569: Added missing 'defer' helpers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/#review50282
-----------------------------------------------------------
ben, can you commit this?
- Vinod Kone
On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24569/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1692
> https://issues.apache.org/jira/browse/MESOS-1692
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
> 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048
>
> Diff: https://reviews.apache.org/r/24569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24569: Added missing 'defer' helpers.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24569/#review50238
-----------------------------------------------------------
Ship it!
This seems to have fixed MESOS-1692. Thanks!
- Brenden Matthews
On Aug. 11, 2014, 6:45 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24569/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-1692
> https://issues.apache.org/jira/browse/MESOS-1692
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781
> 3rdparty/libprocess/include/process/future.hpp db7fcbcff34bcb82c62689e7019b416fdad20048
>
> Diff: https://reviews.apache.org/r/24569/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>