You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/07 00:05:16 UTC

[GitHub] [superset] nytai edited a comment on pull request #12315: feat: provide config to insert html tags on every view

nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-755787917


   @ktmud When we do eventually move to a single page app we can just do a `document.insertAdjacentHTML('beforeEnd', HTML_TEMPLATE_SCRIPT)` as part of the app initialization step in the preamble https://github.com/apache/superset/blob/8f7c7d43a3cfc71e5a58bbe317f65626f839f830/superset-frontend/src/preamble.ts#L32
   
   Or we can keep the current logic in the template we do end up using for all our views (assuming we haven't completely moved off flask/jinja by then) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org