You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 11:02:32 UTC
[jira] [Created] (ZOOKEEPER-1275) ZooKeeper client is only caller
of server.DataTree.copyStat()
ZooKeeper client is only caller of server.DataTree.copyStat()
-------------------------------------------------------------
Key: ZOOKEEPER-1275
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Thomas Koch
Assignee: Thomas Koch
Priority: Minor
This static method should be moved out of the o.a.z.server package. To my knowledge it is the only coupling of ZK client code to server code and the server doesn't even call this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1275) ZooKeeper client is only caller
of server.DataTree.copyStat()
Posted by "Benjamin Reed (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194136#comment-13194136 ]
Benjamin Reed commented on ZOOKEEPER-1275:
------------------------------------------
-1 the right place for this is on Stat, but that is a generated class. if we ever do need to make a copy, ZooKeeper will be a weird place to have it as well. this isn't worth changing
> ZooKeeper client is only caller of server.DataTree.copyStat()
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-1275
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1275.patch
>
>
> This static method should be moved out of the o.a.z.server package. To my knowledge it is the only coupling of ZK client code to server code and the server doesn't even call this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1275) ZooKeeper client is only caller
of server.DataTree.copyStat()
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1275:
------------------------------------
Fix Version/s: (was: 3.5.0)
> ZooKeeper client is only caller of server.DataTree.copyStat()
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-1275
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1275.patch
>
>
> This static method should be moved out of the o.a.z.server package. To my knowledge it is the only coupling of ZK client code to server code and the server doesn't even call this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1275) ZooKeeper client is only caller
of server.DataTree.copyStat()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141071#comment-13141071 ]
Hadoop QA commented on ZOOKEEPER-1275:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501753/ZOOKEEPER-1275.patch
against trunk revision 1195854.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/752//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/752//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/752//console
This message is automatically generated.
> ZooKeeper client is only caller of server.DataTree.copyStat()
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-1275
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1275.patch
>
>
> This static method should be moved out of the o.a.z.server package. To my knowledge it is the only coupling of ZK client code to server code and the server doesn't even call this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1275) ZooKeeper client is only caller
of server.DataTree.copyStat()
Posted by "Thomas Koch (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1275:
-----------------------------------
Attachment: ZOOKEEPER-1275.patch
> ZooKeeper client is only caller of server.DataTree.copyStat()
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-1275
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1275
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1275.patch
>
>
> This static method should be moved out of the o.a.z.server package. To my knowledge it is the only coupling of ZK client code to server code and the server doesn't even call this method.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira