You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "marcingrzejszczak (via GitHub)" <gi...@apache.org> on 2023/07/10 14:56:25 UTC
[GitHub] [camel] marcingrzejszczak opened a new pull request, #10646: Adding additional logging to scope creation and closing
marcingrzejszczak opened a new pull request, #10646:
URL: https://github.com/apache/camel/pull/10646
the problem we have is that one of the spans in one of the tests (most probably MulticastRouteTest) is not being closed and the span is left in the test thread. Due to this other tests are failing.
This commit adds a after test check that there is no leaking span (for OTel and Micrometer Observation modules). Also it adds some additional logging on trace level that will store the stacktrace of each scope and when on close the scope is trying to get closed in a wrong thread we can recreate where it was created and where it's being closed.
After making these changes I can't replicate the issue locally so I'm waiting for it to failed in CI
related to pr gh-10539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #10646: Adding additional logging to scope creation and closing
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #10646:
URL: https://github.com/apache/camel/pull/10646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1632719111
So maybe we shouldn't touch that code unless we see that there are issues? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1629164293
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1631482196
I'll check it out tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1629212167
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 1 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1630785060
Thanks @marcingrzejszczak do you know if we need to backport this to 3.x LTS branches?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1629164257
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 0 | 3 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1629140460
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1629212201
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1632380610
Do we observe any issues with the builds for other branches? Which branches are the LTS ones? 3.21.x, 3.20.x, 3.18.x, 3.14.x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1632539765
I dont think we have seen this, but some of these branches may had a JDK11 compile problem that we didnt got attention (we are busy with v4)
The latest JDK17 on 3.x seems not to have micrometer/observer any problems
https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/camel-3.x/lastCompletedBuild/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1632837952
Yes we assume 3.x is all good for now, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10646: Adding additional logging to scope creation and closing
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10646:
URL: https://github.com/apache/camel/pull/10646#issuecomment-1630758993
I think that should fix things cc @davsclaus @oscerd @ppalaga
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org