[jira] Closed: (AXIS-1611) CommonsHTTPSender does not add HTTP error code to fault details

[ax...@ws.apache.org]

Message:

   The following issue has been closed.

   Resolver: Davanum Srinivas
       Date: Fri, 15 Oct 2004 9:03 AM

Fixed. Please get latest CVS.

thanks,
dims
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1611

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1611
    Summary: CommonsHTTPSender does not add HTTP error code to fault details
       Type: Bug

     Status: Closed
   Priority: Minor
 Resolution: FIXED

    Project: Axis
 Components: 
             Basic Architecture
   Versions:
             1.2RC1

   Assignee: 
   Reporter: Robert H. Pollack

    Created: Fri, 15 Oct 2004 8:35 AM
    Updated: Fri, 15 Oct 2004 9:03 AM
Environment: Any

Description:
When CommonsHTTPSender encounters an HTTP error such as 404 or 401, it creates an AxisFault, but it does not add the error code as a fault detail. The old class, HTTPSender, adds this under a QName reserved for this purpose ({http://xml.apache.org/axis/}HttpErrorCode).

The following statement from HTTPSender.readFromSocket() should be added to CommonsHTTPSender.invoke():

   fault.addFaultDetail(Constants.QNAME_FAULTDETAIL_HTTPERRORCODE,
                    Integer.toString(returnCode));

Not including a separate fault detail requires parsing the error code out of the fault string, which is error-prone and may break if future releases change the format of this string.

By the way, HTTPSender actually implements the enhancement requested by bug 16623 (http://issues.apache.org/bugzilla/show_bug.cgi?id=16623).


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira