[jira] [Updated] (FLINK-8046) ContinuousFileMonitoringFunction wrongly ignores files with exact same timestamp

["Juan Miguel Cejuela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juan Miguel Cejuela updated FLINK-8046:
---------------------------------------
    Release Note:   (was: Easily fixed if now tests are required (no tests exist now for `ContinuousFileMonitoringFunction`) and if the community agrees on the intended behavior (comparison with strictly smaller).

The change can be backported to 1.3.x or 1.4.x)

> ContinuousFileMonitoringFunction wrongly ignores files with exact same timestamp
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-8046
>                 URL: https://issues.apache.org/jira/browse/FLINK-8046
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.3.2
>            Reporter: Juan Miguel Cejuela
>              Labels: stream
>             Fix For: 1.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current monitoring of files sets the internal variable `globalModificationTime` to filter out files that are "older". However, the current test (to check "older") does 
> `boolean shouldIgnore = modificationTime <= globalModificationTime;` (rom `shouldIgnore`)
> The comparison should strictly be SMALLER (NOT smaller or equal). The method documentation also states "This happens if the modification time of the file is _smaller_ than...".
> The equality acceptance for "older", makes some files with same exact timestamp to be ignored. The behavior is also non-deterministic, as the first file to be accepted ("first" being pretty much random) makes the rest of files with same exact timestamp to be ignored.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)