You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gaoxiaolei-s59 (via GitHub)" <gi...@apache.org> on 2026/07/05 12:58:27 UTC
[PR] MINOR: Fix "does not exists" grammatical typos in messages and Javadoc [kafka]
gaoxiaolei-s59 opened a new pull request, #22760:
URL: https://github.com/apache/kafka/pull/22760
Follow-up to #22544, fixing a few more occurrences of the same class of typo found in a repo-wide sweep.
Fixes subject-verb agreement typos ("does not exists" → "does not exist") in user-facing diagnostic messages and Javadoc:
- `StateDirectory` — `@throws` Javadoc: `"does not exists"` → `"does not exist"`
- `TransactionIndex` — `@return` Javadoc: `"doesn't exists"` → `"doesn't exist"`
- `MetadataQuorumCommand` — exception message: `"Properties file ... does not exists!"` → `"...does not exist!"`
Javadoc and string-literal changes only, with no behavior change. The `MetadataQuorumCommandErrorTest` assertion and its test method name are updated to match the corrected message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix "does not exists" grammatical typos in messages and Javadoc [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #22760:
URL: https://github.com/apache/kafka/pull/22760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix "does not exists" grammatical typos in messages and Javadoc [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #22760:
URL: https://github.com/apache/kafka/pull/22760#discussion_r3527451165
##########
tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java:
##########
@@ -168,7 +168,7 @@ private static Properties getProperties(File optionalCommandConfig) throws Terse
return new Properties();
} else {
if (!optionalCommandConfig.exists())
- throw new TerseException("Properties file " + optionalCommandConfig.getPath() + " does not exists!");
+ throw new TerseException("Properties file " + optionalCommandConfig.getPath() + " does not exist!");
Review Comment:
It seems to me that this is a serious tool and an exclamation mark is not ideal. Please change it to just `does not exist.` with a period instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix "does not exists" grammatical typos in messages and Javadoc [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #22760:
URL: https://github.com/apache/kafka/pull/22760#issuecomment-4981878330
Build green apart from flaking `TopologyDescriptionPluginExpirationIntegrationTest > shouldExpireGroupWithoutDeleteTopologyWhenPushPermanentlyFailed`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix "does not exists" grammatical typos in messages and Javadoc [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #22760:
URL: https://github.com/apache/kafka/pull/22760#issuecomment-4979468906
You need to rebase your branch on trunk to resolve the CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org