You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "bjornjorgensen (via GitHub)" <gi...@apache.org> on 2023/03/31 19:10:53 UTC

[GitHub] [spark] bjornjorgensen commented on pull request #40622: fix typo in ResourceRequest.equals()

bjornjorgensen commented on PR #40622:
URL: https://github.com/apache/spark/pull/40622#issuecomment-1492468583

   @thyecust "vendor == vendor is always true"
   
   In line 84 the val vendor field is declared as Optional[String], which means it can have a value of Some(String) when a vendor name is provided, or None when no vendor name is specified.
   
   The failed test is not related to this, can you restart failed test? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org