You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 02:11:29 UTC
[GitHub] [superset] lilykuang opened a new pull request #13585: fix: AntD select dropdown scroll issue
lilykuang opened a new pull request #13585:
URL: https://github.com/apache/superset/pull/13585
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
There is an issue with AntD select https://github.com/ant-design/ant-design/issues/3438. The select popover doesn't move with scrolling.
AntD has provided a [fix](https://ant.design/docs/react/faq) with `getPopupContainer`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
BEFORE:
https://www.loom.com/share/fe9f3933852840859620d92a84a44926
AFTER:
https://www.loom.com/share/47aeef38b3bc44d7a1343e368558a411
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798841855
/testenv up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798841875
@junlincc Ephemeral environment creation is currently limited to committers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-800476218
Ephemeral environment shutdown and build artifacts deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798843359
> @junlincc Ephemeral environment spinning up at http://34.217.214.19:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
@robdiciuccio work like a charm. thank you again!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798843171
@junlincc Ephemeral environment spinning up at http://34.217.214.19:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-797650299
# [Codecov](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=h1) Report
> Merging [#13585](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=desc) (c6a67e4) into [master](https://codecov.io/gh/apache/superset/commit/7656b2e68bff310e4cf9a9225a7751e4172d1120?el=desc) (7656b2e) will **decrease** coverage by `3.89%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13585 +/- ##
==========================================
- Coverage 77.35% 73.46% -3.90%
==========================================
Files 909 605 -304
Lines 46118 21430 -24688
Branches 5649 5562 -87
==========================================
- Hits 35674 15743 -19931
+ Misses 10309 5552 -4757
Partials 135 135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <66.66%> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.36% <80.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `91.66% <66.66%> (-8.34%)` | :arrow_down: |
| [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `91.66% <80.00%> (-8.34%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | | |
| [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | | |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | | |
| [superset/annotation\_layers/dao.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZGFvLnB5) | | |
| [superset/commands/base.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvYmFzZS5weQ==) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| ... and [292 more](https://codecov.io/gh/apache/superset/pull/13585/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=footer). Last update [7656b2e...0c9ee00](https://codecov.io/gh/apache/superset/pull/13585?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798842904
/testenv up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798841855
/testenv up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
lilykuang commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-800431928
> Thanks for the pr @lilykuang! I wonder if there's a fix for popover on scroll? if so, we can take it on.
>
> Screen.Recording.2021-03-13.at.11.30.32.PM.mov
@junlincc I believed `getPopupContainer` will also fix popover on scroll base on ant-design/ant-design#3438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-800469973
@junlincc yup, this same logic should apply to other popups
https://github.com/apache/superset/pull/13585/files#diff-46790d612a7ba54f39c522c7359eba11e45e724e5efe695527c1f96ed45cb8adR107-R111
It's a known issue with antd, and this is their suggested fix. We can probably apply the logic to all "apps" and that should cover all other cases going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798841875
@junlincc Ephemeral environment creation is currently limited to committers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-800802437
Thank you both for clarifying, so we still need separate PRs that apply this logic to other components, right? i looked master, popover is still disconnected on scroll. @nytai 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798851897
Thanks for the pr @lilykuang! I wonder if there's a fix for popover on scroll? if so, we can take it on.
https://user-images.githubusercontent.com/67837651/111060878-f2c44380-8454-11eb-95f5-d9500cd59909.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] willbarrett commented on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-801459930
Yes, that's correct @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #13585:
URL: https://github.com/apache/superset/pull/13585#issuecomment-798843359
> @junlincc Ephemeral environment spinning up at http://34.217.214.19:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
@robdiciuccio work like a charm. thank you again!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang merged pull request #13585: fix: AntD select dropdown scroll issue
Posted by GitBox <gi...@apache.org>.
lilykuang merged pull request #13585:
URL: https://github.com/apache/superset/pull/13585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org