You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2025/05/08 05:46:03 UTC

Re: [PR] Create new CI workflow and run unit tests using it (druid)

abhishekrb19 commented on code in PR #17700:
URL: https://github.com/apache/druid/pull/17700#discussion_r2078930370


##########
processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerBenchmark.java:
##########
@@ -46,6 +46,7 @@
 /**
  * Based on TopNQueryRunnerTest
  */
+@Ignore

Review Comment:
   @Akshat-Jain @kgyrtkirk I was curious why this benchmark was ignored in this patch. Was it related to the switch to jdk 17 that caused the test to start failing? I was trying to run it locally and noticed some memory leaks from the "stupid pool" (which showed up in jdk 17 runs but not with jdk 11?), so I just wanted to check that a legitimate issue wasn’t being masked here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org