You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (Jira)" <ji...@apache.org> on 2022/11/04 07:53:00 UTC
[jira] [Work started] (WW-4514) DefaultUrlHelper.buildParametersString appends just ? if collection is empty
[ https://issues.apache.org/jira/browse/WW-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WW-4514 started by Lukasz Lenart.
-----------------------------------------
> DefaultUrlHelper.buildParametersString appends just ? if collection is empty
> ----------------------------------------------------------------------------
>
> Key: WW-4514
> URL: https://issues.apache.org/jira/browse/WW-4514
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.24
> Reporter: Jasper Rosenberg
> Assignee: Lukasz Lenart
> Priority: Trivial
> Fix For: 6.1.0
>
> Attachments: DefaultUrlHelper.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DefaultUrlHelper.buildParametersString() checks that it has parameters to append before adding the first "?"/"&", but if the only parameters are empty Iterables/Arrays, then it shouldn't do that.
> I'd suggest adding the new query string to a StringBuilder, and then if it is non-empty, append that with the separator to the link at the end. (See patch)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)