You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/07/20 08:12:03 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

bartekkuncer opened a new pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459


   ## Description ##
   SoftmaxOutput was backported as a part of https://github.com/apache/incubator-mxnet/pull/20131. Only part of the code was backported. As the define encapsulating backported parts is obsolete (therefore set to OFF), this did not break CI. This change fixes the define name and complements the backport.
   
   ## Checklist ##
   
   ### Changes ###
   - [x] Fix define name
   - [x] Backport missing parts of SoftmaxOutput implementation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883391100


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883320124


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883391024


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883320070


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883320070


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883193438






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883193438


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, edge, windows-gpu, miscellaneous, unix-cpu, unix-gpu, sanity, clang, centos-cpu, windows-cpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883483223


   @mxnet-bot run ci [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883193438


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, edge, windows-gpu, miscellaneous, unix-cpu, unix-gpu, sanity, clang, centos-cpu, windows-cpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459#issuecomment-883483278


   Jenkins CI successfully triggered : [unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] akarbown merged pull request #20459: [BUGFIX] Fix backport of SoftmaxOutput implementation using onednn kernels

Posted by GitBox <gi...@apache.org>.
akarbown merged pull request #20459:
URL: https://github.com/apache/incubator-mxnet/pull/20459


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org