You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/28 16:35:10 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #359: add license header to sbt files
pjfanning opened a new pull request, #359:
URL: https://github.com/apache/incubator-pekko/pull/359
The CopyrightHeader.scala change to apply headers to `.sbt` files didn't actually have an effect. I then manually added the headers. I left the CopyrightHeader.scala change there just in case a future version of sbt-header checks the `.sbt` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #359: add license header to sbt files
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #359:
URL: https://github.com/apache/incubator-pekko/pull/359#issuecomment-1566198120
> The CopyrightHeader.scala change to apply headers to `.sbt` files didn't actually have an effect.
Yes I am aware of this issue, I think its due to a peculiarity where sbt plugins cannot see sources of the sbt build files themselves unless you add `sbt-license-header` as a plugin to your sbt plugins.
Anyways this should do for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #359: add license header to sbt files
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #359:
URL: https://github.com/apache/incubator-pekko/pull/359#issuecomment-1566410489
If it doesn't take effect for sbt files, then I think the resources are not included, but that can be done in the following PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #359: add license header to sbt files
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #359:
URL: https://github.com/apache/incubator-pekko/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org