You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2008/12/10 05:18:03 UTC
Re: svn commit: r724818 - /geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
Hey, you really should not rely on system environment variables here,
as that kinda defeats the purpose of using the svn-based controllers
for all configuration.
I'd recommend you revert this and setup defaults in the controllers.
--jason
On Dec 10, 2008, at 1:50 AM, jawarner@apache.org wrote:
> Author: jawarner
> Date: Tue Dec 9 10:50:26 2008
> New Revision: 724818
>
> URL: http://svn.apache.org/viewvc?rev=724818&view=rev
> Log:
> Pull maven opts from agent environment
>
> Modified:
> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/
> system/commands/MavenCommand.groovy
>
> Modified: geronimo/sandbox/build-support/libraries/system/1/groovy/
> gbuild/system/commands/MavenCommand.groovy
> URL: http://svn.apache.org/viewvc/geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy?rev=724818&r1=724817&r2=724818&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/
> system/commands/MavenCommand.groovy (original)
> +++ geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/
> system/commands/MavenCommand.groovy Tue Dec 9 10:50:26 2008
> @@ -32,7 +32,7 @@
>
> def mavenHome = 'tools/maven'
>
> - def mavenOpts = null
> + def mavenOpts = System.getenv('MAVEN_OPTS')
>
> def repoDir = 'repository'
>
>
>
Re: svn commit: r724818 - /geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
Posted by Jason Warner <ja...@gmail.com>.
You are correct, sir.
On Tue, Dec 9, 2008 at 11:18 PM, Jason Dillon <ja...@planet57.com> wrote:
> Hey, you really should not rely on system environment variables here, as
> that kinda defeats the purpose of using the svn-based controllers for all
> configuration.
>
> I'd recommend you revert this and setup defaults in the controllers.
>
> --jason
>
>
>
> On Dec 10, 2008, at 1:50 AM, jawarner@apache.org wrote:
>
> Author: jawarner
>> Date: Tue Dec 9 10:50:26 2008
>> New Revision: 724818
>>
>> URL: http://svn.apache.org/viewvc?rev=724818&view=rev
>> Log:
>> Pull maven opts from agent environment
>>
>> Modified:
>>
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>>
>> Modified:
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> URL:
>> http://svn.apache.org/viewvc/geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy?rev=724818&r1=724817&r2=724818&view=diff
>>
>> ==============================================================================
>> ---
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> (original)
>> +++
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> Tue Dec 9 10:50:26 2008
>> @@ -32,7 +32,7 @@
>>
>> def mavenHome = 'tools/maven'
>>
>> - def mavenOpts = null
>> + def mavenOpts = System.getenv('MAVEN_OPTS')
>>
>> def repoDir = 'repository'
>>
>>
>>
>>
>
--
~Jason Warner