[jira] [Commented] (IMPALA-15228) The dockerized test driver script is not compatible with Ninja

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-15228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106438#comment-18106438 ] 

ASF subversion and git services commented on IMPALA-15228:
----------------------------------------------------------

Commit ba8fa50e6f197b8d6c325901535391d33119ad6a in impala's branch refs/heads/master from Laszlo Gaal
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ba8fa50e6 ]

IMPALA-15228: Make dockerised test driver script compatible with Ninja

The dockerised test driver script bin/jenkins/dockerized-impala-run-tests.sh
contains a direct call to "make", which can cause a build failure if the
whole build is run with Ninja (by launching buildall.sh with the -ninja
option).

This patch replaces the direct "make" call with indirecting the call
through ${IMPALA_MAKE_CMD} to call the build-specific make tool.

Change-Id: I235c18893babde229f0c03c402b8ec87594d765b
Reviewed-on: http://gerrit.cloudera.org:8080/24644
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>


> The dockerized test driver script is not compatible with Ninja
> --------------------------------------------------------------
>
>                 Key: IMPALA-15228
>                 URL: https://issues.apache.org/jira/browse/IMPALA-15228
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 5.0.0
>            Reporter: Laszlo Gaal
>            Assignee: Laszlo Gaal
>            Priority: Major
>             Fix For: Impala 5.0.0
>
>
> The Dockerized test driver script bin/jenkins/dockerized-impala-run-tests.sh contains a direct call to {{{}make{}}}, making the script incompatible with runs that use Ninja as the make tool.
> Since Impala started relying more on Ninja for better concurrency management during compile and link phases, this can now cause problems.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org