You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/09/16 22:58:34 UTC
[PR] fix(migrations): merge theme editors and purge audit heads [superset]
aminghadersohi opened a new pull request, #44364:
URL: https://github.com/apache/superset/pull/44364
### SUMMARY
`master` currently has **two alembic heads**, so `superset db upgrade` aborts before applying anything:
```
ERROR [flask_migrate] Error: Multiple head revisions are present for given argument 'head';
please specify a specific target revision, '<branchname>@head' to narrow to a specific head,
or 'heads' for all heads
```
The two heads are:
| revision | down_revision |
|---|---|
| `e2f3a1b9c640` — merge purge-audit pruning and username index heads | `("c7f53d184ea2", "88a01c781622")` |
| `0884f655c0a6` — merge task_dependencies with theme_editors heads | `("7e2c9a4f1b83", "aa5fa339627c")` |
Neither is an ancestor of the other. The themes branch was long-lived and carried its own merge revisions, which were computed against a `master` that predated `e2f3a1b9c640`; merging it re-branched the graph.
This PR adds a single empty merge revision (`60f94cd6cd11`) with `down_revision = ("0884f655c0a6", "e2f3a1b9c640")`. **There is no schema or data change** — `upgrade()` and `downgrade()` are empty. It mirrors the shape of the prior merge revision in `e2f3a1b9c640`.
This unblocks integration CI repo-wide: every open PR's integration legs are dying in 1–2 minutes on this signature, before any tests run, including PRs that add no migrations at all.
Note that the `enforce-single-migration-head` check does not catch this class of break, because it only inspects the migrations a PR itself adds. It passes green on PRs that are being broken by `master`'s divergent graph, so its status says nothing about whether `master`'s graph has converged.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — migration graph change only.
### TESTING INSTRUCTIONS
Against a fresh SQLite metadata database:
```bash
# Before this change
$ superset db heads
0884f655c0a6 (head)
e2f3a1b9c640 (head)
$ superset db upgrade
ERROR [flask_migrate] Error: Multiple head revisions are present for given argument 'head' ...
# After this change
$ superset db heads
60f94cd6cd11 (head)
$ superset db upgrade
INFO [alembic.runtime.migration] Running upgrade 0884f655c0a6, e2f3a1b9c640 -> 60f94cd6cd11,
Merge theme editors and purge audit heads.
# completes successfully
```
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(migrations): merge theme editors and purge audit heads [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44364:
URL: https://github.com/apache/superset/pull/44364#issuecomment-5705927505
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44364?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 80.24%. Comparing base ([`7b6dd75`](https://app.codecov.io/gh/apache/superset/commit/7b6dd7597c4af49f7f0571b7b33dd247f382218b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`77ef39f`](https://app.codecov.io/gh/apache/superset/commit/77ef39fcaaaf5170b8e828a69953a98ca4ca46f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44364 +/- ##
==========================================
- Coverage 80.30% 80.24% -0.07%
==========================================
Files 2929 2930 +1
Lines 174172 174300 +128
Branches 40450 40461 +11
==========================================
- Hits 139873 139867 -6
- Misses 31642 31743 +101
- Partials 2657 2690 +33
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.17% <ø> (+0.01%)` | :arrow_up: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.24% <ø> (+<0.01%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.56% <ø> (-0.13%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.33% <ø> (+0.03%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/44364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.30% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44364?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(migrations): merge theme editors and purge audit heads [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44364:
URL: https://github.com/apache/superset/pull/44364#issuecomment-5707576046
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(migrations): merge theme editors and purge audit heads [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #44364:
URL: https://github.com/apache/superset/pull/44364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(migrations): merge theme editors and purge audit heads [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44364:
URL: https://github.com/apache/superset/pull/44364#issuecomment-5705735609
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(migrations): merge theme editors and purge audit heads [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #44364:
URL: https://github.com/apache/superset/pull/44364#issuecomment-5705962080
Reviewed `77ef39fcaaaf5170b8e828a69953a98ca4ca46f4` against `7b6dd7597c4af49f7f0571b7b33dd247f382218b` with Python, SQLAlchemy/Alembic, and Superset-committer lenses (automated review).
**No blocking correctness findings from the Python and migration reviews.** The full migration graph has exactly the two expected parent heads before this change and only `60f94cd6cd11` afterward. Alembic 1.15.2 graph traversal confirms that starting from either parent still includes the missing other branch. Both empty callbacks are appropriate for this merge-only revision.
One nonblocking typing nit at lines 26–27: under our strict assignment-annotation convention, prefer `revision: str` and `down_revision: tuple[str, str]`. The existing migration template emits unannotated identifiers, so this is not a correctness issue or a reason to hold up the repair.
Verification limits: graph analysis and direct no-op callback execution, not an independently executed database upgrade/downgrade round trip. Please complete the migration checklist with actual downgrade verification and runtime/downtime evidence.
At the final check, migration guards, SQLite integration, pre-commit and unit tests passed; MySQL/PostgreSQL integration were still running, with no failed checks observed. The committer lens therefore remained process-only under its CI-first rule, not a completed code approval. Required migration approvals and remaining CI still apply; this comment is not a substitute for maintainer approval.
The merge-time guard improvement that would prevent recurrence can be handled separately from this focused repair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org