You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 22:57:35 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27260: Print important information outside of the folded output in CI

jedcunningham commented on code in PR #27260:
URL: https://github.com/apache/airflow/pull/27260#discussion_r1005028693


##########
dev/breeze/src/airflow_breeze/utils/parallel.py:
##########
@@ -352,6 +354,11 @@ def check_async_run_results(
     :param include_success_outputs: include outputs of successful parallel runs
     :param poll_time: what's the poll time between checks
     :param skip_cleanup: whether to skip cleanup of temporary files.
+    :param print_summary_after_line_matching: if it is not None, the regexp determines line after which
+        outputs should be printed as summary, so that you do not have to look at the folded details of
+        the run in CI
+    :param print_summary_also_after_success: if summary is printed, this flag determines if summaries should

Review Comment:
   ```suggestion
       :param print_summary_after_success: if summary is printed, this flag determines if summaries should
   ```
   
   I think we can drop "also"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org