[jira] [Commented] (BEAM-7970) Regenerate Go SDK proto files in correct version

["Daniel Oliveira (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924656#comment-16924656 ] 

Daniel Oliveira commented on BEAM-7970:
---------------------------------------

From my PR attempt:
{quote}Closing because it turns out attempting to regen protos with an updated version of the proto compiler also requires updating a bunch of the Go SDK's dependencies, which is a huge can of worms.

And it's mostly unnecessary anyway. The real way to avoid issues is to use an older version of the proto compiler, so the change that really needs to be made is updating the documentation to mention which version to use.
{quote}
So I'll be making a PR modifying the message instead and closing this for now.

> Regenerate Go SDK proto files in correct version
> ------------------------------------------------
>
>                 Key: BEAM-7970
>                 URL: https://issues.apache.org/jira/browse/BEAM-7970
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Generated proto files in the Go SDK currently include this bit:
> {{// This is a compile-time assertion to ensure that this generated file}}
> {{// is compatible with the proto package it is being compiled against.}}
> {{// A compilation error at this line likely means your copy of the}}
> {{// proto package needs to be updated.}}
> {{const _ = proto.ProtoPackageIsVersion2 // please upgrade the proto package}}
>  
> This indicates that the protos are being generated as proto v2 for whatever reason. Most likely, as mentioned by this post with someone with a similar issue, because the proto generation binary needs to be rebuilt before generating the files again: [https://github.com/golang/protobuf/issues/449#issuecomment-340884839]
> This hasn't caused any errors so far, but might eventually cause errors if we hit version differences between the v2 and v3 protos.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)