You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/08/06 18:10:24 UTC
Review Request 68238: Fixed `mesos-style.py` for Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68238/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
Due to an unfortunate platform difference, the `virtualenv` subfolder
is `Script` instead of `bin` on Windows.
Some hacky inline scripting was done to mimic the shell script
`build-virtualenv` to build the `virtualenv` on Windows.
Diffs
-----
support/python3/mesos-style.py 12fd33061fcb2cb04349ec1138844ea712610259
Diff: https://reviews.apache.org/r/68238/diff/1/
Testing
-------
Can commit using normal hooks on Windows.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68238: Fixed `mesos-style.py` for Windows.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68238/#review206902
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Aug. 6, 2018, 6:10 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68238/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 6:10 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to an unfortunate platform difference, the `virtualenv` subfolder
> is `Script` instead of `bin` on Windows.
>
> Some hacky inline scripting was done to mimic the shell script
> `build-virtualenv` to build the `virtualenv` on Windows.
>
>
> Diffs
> -----
>
> support/python3/mesos-style.py 12fd33061fcb2cb04349ec1138844ea712610259
>
>
> Diff: https://reviews.apache.org/r/68238/diff/1/
>
>
> Testing
> -------
>
> Can commit using normal hooks on Windows.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>