[GitHub] [couchdb] big-r81 commented on a diff in pull request #4094: Replace Sha-1 with Sha-256 for cookie authentication

[GitBox <gi...@apache.org>]

big-r81 commented on code in PR #4094:
URL: https://github.com/apache/couchdb/pull/4094#discussion_r917041592


##########
test/elixir/test/proxyauth_test.exs:
##########
@@ -62,11 +62,9 @@ defmodule ProxyAuthTest do
     |> Enum.join("")
   end
 
-  defp hex_hmac_sha1(secret, message) do
+  defp hex_hmac_sha256(secret, message) do
     signature = case :erlang.system_info(:otp_release) do
-      '20' -> :crypto.hmac(:sha, secret, message)

Review Comment:
   @nickva I removed the tests for this old erlang versions, because we are on OTP 23+. Is it okay?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org