You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2024/04/09 14:01:51 UTC
[PR] [Fix](hive-writer) Cherry pick 32721,32775. [doris]
kaka11chen opened a new pull request, #33443:
URL: https://github.com/apache/doris/pull/33443
## Proposed changes
Cherry pick #32721 #32775.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](hive-writer) Cherry pick 32721,32775. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen closed pull request #33443: [Fix](hive-writer) Cherry pick 32721,32775.
URL: https://github.com/apache/doris/pull/33443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](hive-writer) Cherry pick 32721,32775. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #33443:
URL: https://github.com/apache/doris/pull/33443#discussion_r1557705951
##########
be/src/vec/sink/writer/vhive_partition_writer.cpp:
##########
@@ -135,17 +136,18 @@ Status VHivePartitionWriter::open(RuntimeState* state, RuntimeProfile* profile)
}
}
-Status VHivePartitionWriter::close(Status status) {
- if (_vfile_writer != nullptr) {
- Status st = _vfile_writer->close();
- if (st != Status::OK()) {
- LOG(WARNING) << fmt::format("_vfile_writer close failed, reason: {}", st.to_string());
+Status VHivePartitionWriter::close(const Status& status) {
Review Comment:
warning: method 'close' can be made static [readability-convert-member-functions-to-static]
be/src/vec/sink/writer/vhive_partition_writer.h:58:
```diff
- Status close(const Status& status);
+ static Status close(const Status& status);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](hive-writer) Cherry pick 32721,32775. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33443:
URL: https://github.com/apache/doris/pull/33443#issuecomment-2045253537
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org