[GitHub] [incubator-pinot] kishoreg commented on pull request #6664: Add an option to fail segment creation job when getting empty files

[GitBox <gi...@apache.org>]

kishoreg commented on pull request #6664:
URL: https://github.com/apache/incubator-pinot/pull/6664#issuecomment-795805303


   I don't think this handling all the cases properly. This is just checking if recordreader.next is empty which is handling empty input file but it's not handling the case where all rows get filtered. It's probably better to check for 0 records at the seal which will catch a lot of other use cases. 
   
   Also, this flag is not being passed from the segmentGeneration command
   
    @npawar please take a look at this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org