You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/18 12:10:33 UTC
[GitHub] [incubator-inlong] herywang opened a new pull request #2589: [INLONG-2588][manager] Support cluster management
herywang opened a new pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589
Fixes #2588
### Motivation
*Adding some method to support cluster management.*
### Modifications
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2589: [INLONG-2588][Manager] Support cluster management
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang commented on a change in pull request #2589: [INLONG-2588][Manager] Support cluster management
Posted by GitBox <gi...@apache.org>.
herywang commented on a change in pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589#discussion_r810446769
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
Review comment:
**I will modify this problem in the next issue and pull request.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #2589: [INLONG-2588][Manager] Support cluster management
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589#issuecomment-1045609168
@herywang please do not remove the `.idea/vcs.xml` file, it's useful to link the valid issues or PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #2589: [INLONG-2588][Manager] Support cluster management
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589#discussion_r810436749
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
+ @ApiOperation(value = "Add a cluster info")
+ @OperationLog(operation = OperationType.CREATE)
+ public Response<Integer> saveCluster(@RequestBody ClusterInfo clusterInfo) {
+ String currentUser = LoginUserUtil.getLoginUserDetail().getUserName();
+ return Response.success(clusterInfoService.save(clusterInfo, currentUser));
+ }
+
+ @RequestMapping(value = "/common/get/{id}")
Review comment:
ditto
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
Review comment:
what does the `common` stand for? it's better to use an explicit name.
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
+ @ApiOperation(value = "Add a cluster info")
+ @OperationLog(operation = OperationType.CREATE)
+ public Response<Integer> saveCluster(@RequestBody ClusterInfo clusterInfo) {
+ String currentUser = LoginUserUtil.getLoginUserDetail().getUserName();
+ return Response.success(clusterInfoService.save(clusterInfo, currentUser));
+ }
+
+ @RequestMapping(value = "/common/get/{id}")
+ @ApiOperation(value = "Query cluster information of the common")
+ @ApiImplicitParam(name = "id", value = "common cluster ID", dataTypeClass = Integer.class, required = true)
+ public Response<ClusterInfo> getCluster(@PathVariable Integer id) {
+ return Response.success(clusterInfoService.get(id));
+ }
+
+ @RequestMapping(value = "/common/update", method = RequestMethod.POST)
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] herywang commented on a change in pull request #2589: [INLONG-2588][Manager] Support cluster management
Posted by GitBox <gi...@apache.org>.
herywang commented on a change in pull request #2589:
URL: https://github.com/apache/incubator-inlong/pull/2589#discussion_r810446868
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
+ @ApiOperation(value = "Add a cluster info")
+ @OperationLog(operation = OperationType.CREATE)
+ public Response<Integer> saveCluster(@RequestBody ClusterInfo clusterInfo) {
+ String currentUser = LoginUserUtil.getLoginUserDetail().getUserName();
+ return Response.success(clusterInfoService.save(clusterInfo, currentUser));
+ }
+
+ @RequestMapping(value = "/common/get/{id}")
Review comment:
I will modify this problem in the next issue and pull request.
##########
File path: inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/ClusterController.java
##########
@@ -58,6 +59,37 @@
return Response.success(clusterInfoService.list(request));
}
+ @RequestMapping(value = "/common/save", method = RequestMethod.GET)
+ @ApiOperation(value = "Add a cluster info")
+ @OperationLog(operation = OperationType.CREATE)
+ public Response<Integer> saveCluster(@RequestBody ClusterInfo clusterInfo) {
+ String currentUser = LoginUserUtil.getLoginUserDetail().getUserName();
+ return Response.success(clusterInfoService.save(clusterInfo, currentUser));
+ }
+
+ @RequestMapping(value = "/common/get/{id}")
+ @ApiOperation(value = "Query cluster information of the common")
+ @ApiImplicitParam(name = "id", value = "common cluster ID", dataTypeClass = Integer.class, required = true)
+ public Response<ClusterInfo> getCluster(@PathVariable Integer id) {
+ return Response.success(clusterInfoService.get(id));
+ }
+
+ @RequestMapping(value = "/common/update", method = RequestMethod.POST)
Review comment:
I will modify this problem in the next issue and pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org