[GitHub] [incubator-devlake] e2corporation commented on pull request #2002: feat(frontend): change jira basicauthencode to username/password

[GitBox <gi...@apache.org>]

e2corporation commented on PR #2002:
URL: https://github.com/apache/incubator-devlake/pull/2002#issuecomment-1137309227

   Another needed patch is to apply the silent Inline validation rule to the `username` and `password` inputs so the errors are not emphasized by default (see connection-name-input as reference).  The InputGroup needs to be updated for these fields, className and rightElement need to be adjusted.
   
   ```
   # Use of rightElement Inline Validation
    <InputGroup
       .......
       .......
        className={`input input-proxy ${fieldHasError('Proxy') ? 'invalid-field' : ''}`}
        rightElement={(
                     <InputValidationError
                       error={getFieldError('Username')}
            />
        )}
   
   />
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org