You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/04/30 02:52:33 UTC
[GitHub] [rocketmq-client-python] ysjjovo opened a new pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
ysjjovo opened a new pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90
## What is the purpose of the change
Repair consumer usage in 'README.md'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-python] messense commented on a change in pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
Posted by GitBox <gi...@apache.org>.
messense commented on a change in pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90#discussion_r417727120
##########
File path: README.md
##########
@@ -72,13 +72,15 @@ producer.shutdown()
### PushConsumer
```python
+from rocketmq.client import PushConsumer, ConsumeStatus
import time
from rocketmq.client import PushConsumer
Review comment:
You can remove this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-python] codecov-io edited a comment on pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90#issuecomment-621582725
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=h1) Report
> Merging [#90](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-python/commit/44824e4c20a04dbe0ab18adb499998c5c9156b74&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 4 4
Lines 528 528
=======================================
Hits 434 434
Misses 94 94
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=footer). Last update [44824e4...431fa3c](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-python] codecov-io commented on pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90#issuecomment-621582725
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=h1) Report
> Merging [#90](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-python/commit/44824e4c20a04dbe0ab18adb499998c5c9156b74&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 4 4
Lines 528 528
=======================================
Hits 434 434
Misses 94 94
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=footer). Last update [44824e4...2016b48](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-python] codecov-io edited a comment on pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90#issuecomment-621582725
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=h1) Report
> Merging [#90](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-python/commit/44824e4c20a04dbe0ab18adb499998c5c9156b74&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 4 4
Lines 528 528
=======================================
Hits 434 434
Misses 94 94
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=footer). Last update [44824e4...2016b48](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-python] codecov-io edited a comment on pull request #90: [ISSUE #88]Sample Callback should return ConsumeStatus
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #90:
URL: https://github.com/apache/rocketmq-client-python/pull/90#issuecomment-621582725
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=h1) Report
> Merging [#90](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-python/commit/44824e4c20a04dbe0ab18adb499998c5c9156b74&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 4 4
Lines 528 528
=======================================
Hits 434 434
Misses 94 94
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=footer). Last update [44824e4...431fa3c](https://codecov.io/gh/apache/rocketmq-client-python/pull/90?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org