You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/01/25 15:14:32 UTC
[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3215
[FLINK-5628] [webfrontend] Fix serialization of stats tracker
Instead of exposing the stats tracker in `AccessExecutionGraph`, we expose the checkpoint stats snapshot. That way, we don't have to worry about serializibility in the tracker itself. The archived execution graph simply gets the latest snapshot before archival. With this change, we also prevent illegal use of the tracker after it has been archived.
Not strictly necessary for 1.2 but nice to have in order to have an easier time when backporting stuff from 1.3 later.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink serialize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3215
----
commit 4edc2169d70a90cc8e50462a684c5593ae0b0eb3
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-01-25T14:42:24Z
[FLINK-5628] [webfrontend] Return snapshot instead of tracker
commit fc99a5ed096848c9794e8be9928ac5ad3f8027f0
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-01-25T14:43:18Z
[FLINK-5628] [webfrontend] Fix serializability of checkpoint stats tracker
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
@uce +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3215
Thanks for review. I'm going to merge this to `release-1.2` as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3215#discussion_r97799769
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ArchivedExecutionGraph.java ---
@@ -105,10 +110,12 @@ public ArchivedExecutionGraph(
this.serializedUserAccumulators = serializedUserAccumulators;
this.archivedExecutionConfig = executionConfig;
this.isStoppable = isStoppable;
- this.tracker = tracker;
+ this.jobSnapshottingSettings = checkNotNull(jobSnapshottingSettings);
+ this.checkpointStatsSnapshot = checkNotNull(checkpointStatsSnapshot);
--- End diff --
so these are not null even when checkpointing is disabled?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3215#discussion_r97799282
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java ---
@@ -85,6 +79,9 @@
/** History of checkpoints. */
private final CheckpointStatsHistory history;
+ /** The job vertices taking part in the checkpoints. */
+ private final transient List<ExecutionJobVertex> jobVertices;
--- End diff --
doesn't have to be transient anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
add `SubtaskStateStats` to the list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
I think the `CompletedCheckpointStats` class must also implement `Serializable`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3215: [FLINK-5628] [webfrontend] Fix serialization of st...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3215
Thanks for spotting these. I'll adress your points.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3215: [FLINK-5628] [webfrontend] Fix serialization of stats tra...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3215
as well as the and the `AbstractCheckpointStats` class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---