You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Cyrille Morvan <cy...@ingenosya.com> on 2001/12/26 11:48:00 UTC
[PATCH] ejb-jar/jonas element again
Hello again !
I sended my patch two times : a few weeks ago and a few days ago.
I will send my files until they will be commited or a someone gives a good
reason to not do it !
There is a JBoss version of the DeploymentTool and Ant must have a JOnAS
version !
Thank you.
-----------------------------------------------------------
Date: Mon, 24 Dec 2001 15:54:08 +0100
To: ant-dev@jakarta.apache.org
From: Cyrille Morvan <cy...@ingenosya.com>
Subject: [PATCH] [SUBMIT] ejb-jar/jonas element for ANT
Cc: jonas-users@objectweb.org
Hello,
Enclosed a new version of my add-on to deploy Enterprise Java Bean in JOnAS
from ANT.
JOnAS is the Java Open Application Server, it's a good opensource EJB
container from ObjectWeb.
Find it on http://www.objectweb.org/jonas/
There are 2 patches and a new file :
-- EjbJar.java.patch prodives a new method to the task ejb-jar
jakarta-ant\src\main\org\apache\tools\ant\taskdefs\optional\ejb\EjbJar.java
-- ejb.html.patch provides a new paragraph, how to use the new jonas
element as the WebLogic, IPlanet or the JBoss elements.
jakarta-ant/docs/manual/OptionalTasks/ejb.html
-- JonasDeploymentTool.java is a new file to commit into
jakarta-ant\src\main\org\apache\tools\ant\taskdefs\optional\ejb\JonasDeploymentTool.java
Examples :
<ejbjar srcdir="${build.classes}"
descriptordir="${descriptor.dir}">
<jonas destdir="${deploymentjars.dir}"
jonasroot="${jonas.root}"
orb="RMI" />
<include name="**/*.xml"/>
<exclude name="**/jonas-*.xml"/>
</ejbjar>
<ejbjar srcdir="${build.classes}"
descriptordir="${descriptor.dir}"
basejarname="TheEJBJar">
<jonas destdir="${deploymentjars.dir}" jonasroot="${jonas.root}"
suffix=".jar" orb="JEREMIE"
classpath="${descriptorbuild.classpath}" />
<include name="**/ejb-jar.xml"/>
<exclude name="**/jonas-ejb-jar.xml"/>
</ejbjar>
I will be very _happy_, if the Apache Ant team could commit my work before
Ant 1.5 !
Thank you !
Merry xmas to the Apache Ant Dev Team and Jonas users list.
--
Cyrille Morvan
IT Engineering student - FiiFo - University Paris-Sud
Re: [PATCH] ejb-jar/jonas element again
Posted by Cyrille Morvan <cy...@ingenosya.com>.
At 17:41 26/12/2001 -0800, you wrote:
>----- Original Message -----
>From: "Cyrille Morvan" <cy...@ingenosya.com>
>To: <an...@jakarta.apache.org>
>Sent: Wednesday, December 26, 2001 2:48 AM
>Subject: [PATCH] ejb-jar/jonas element again
>
>Regarding why you hadnt heard anything since last time, well, I guess that
>meant nobody else on ant-dev had been using JOnAS, so there was nobody ready
>to pick up your app and play with it. We prefer to have broader experience
>and maybe even some test cases before committing something, because it then
>becomes our support problem.
>
>We do need somebody else to play with this before I am happy commiting it,
>even though I agree that a jonas task would be a worthy addition to Ant -or
>the JOnAS codebase.
Hello,
This message is for people interested in EJB jar deployment on JOnAS.
You can download my own Ant distribution from :
http://ingenosya.com/ant/
It's support the ejb-jar/jonas element.
I need people to test it, and make feedback on jonas-users@objectweb.org list,
to help me and JOnAS developers to improve the new task.
http://ingenosya.com/ant/unofficial-jakarta-ant-1.5alpha-jonas-bin.zip is
a binary distribution.
http://ingenosya.com/ant/unofficial-jakarta-ant-1.5alpha-jonas-src.zip is
the source
http://ingenosya.com/ant/ejb-jar_documentation.html is the documentation
http://ingenosya.com/ant/jonas-ejbjar.tar.gz is JOnAS EJB examples with a
build.xml file.
We catch some problems, see them in archive :
http://www.objectweb.org/wws/info/jonas
it's based on the Wenesday 26 of december 2001 CVS check out.
--
Cyrille Morvan
IT Engineering student from University Paris-Sud - FIIFO
Ingenosya Company
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] ejb-jar/jonas element again
Posted by Cyrille Morvan <cy...@ingenosya.com>.
Thank you steve for your long and useful answer !
(see my answers)
At 17:41 26/12/2001 -0800, you wrote:
>----- Original Message -----
>From: "Cyrille Morvan" <cy...@ingenosya.com>
>To: <an...@jakarta.apache.org>
>Sent: Wednesday, December 26, 2001 2:48 AM
>Subject: [PATCH] ejb-jar/jonas element again
>
>.....
>
>We do need somebody else to play with this before I am happy commiting it,
>even though I agree that a jonas task would be a worthy addition to Ant -or
>the JOnAS codebase.
Many JOnAS users work with Ant. I will ask to this people to play with the
new element,
so I will send their feedbacks to this mailing list.
>I had been a bit concerned about the fact that JOnAS is
>GPL, and we cant have GPL code in the Apache source tree, but since you are
>only calling it via a <java> call I think we should be ok on that. Correct?
JOnAS isn't GPL. JOnAS license is close to the Mozilla Public License
version 1.1 (MPL1.1)
The IPlanet, WebLogic and WebSphere element use a <java> call to run their
own tools which are not OpenSource.
So I think, there is no problem.
>So the primary issue is that it'd be nice to get some input from other JOnAS
>users. If we dont, well, we could commit it and then field the feedback
>which will come in. Like most optional tasks which arent testable on most
>systems its hard to keep these tasks alive without the involvement of the
>original author and users.
Be sure the JOnAS team and I will maintain the task, and will not let it die.
>Before we get that far, there are some bits in the code that, while
>workable, are not really what we want in the codebase:
>.....
>
>So, why not make the changes, add a junit test class which stresses the task
>and start harassing us a week or so into January, when people are back from
>their holidays.
Thank you for all your remarks.
I would do my best, to make the better task I can.
I hope my work will be commited in January.
Thank you again for all your advices.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] ejb-jar/jonas element again
Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Cyrille Morvan" <cy...@ingenosya.com>
To: <an...@jakarta.apache.org>
Sent: Wednesday, December 26, 2001 2:48 AM
Subject: [PATCH] ejb-jar/jonas element again
> Hello again !
>
> I sended my patch two times : a few weeks ago and a few days ago.
>
> I will send my files until they will be commited or a someone gives a good
> reason to not do it !
>
> There is a JBoss version of the DeploymentTool and Ant must have a JOnAS
> version !
>
>
> Thank you.
>
well, it is the xmas week and everyone is away. So no, you shouldnt have
expected anything to have happened over this week.
Regarding why you hadnt heard anything since last time, well, I guess that
meant nobody else on ant-dev had been using JOnAS, so there was nobody ready
to pick up your app and play with it. We prefer to have broader experience
and maybe even some test cases before committing something, because it then
becomes our support problem.
We do need somebody else to play with this before I am happy commiting it,
even though I agree that a jonas task would be a worthy addition to Ant -or
the JOnAS codebase.
I had been a bit concerned about the fact that JOnAS is
GPL, and we cant have GPL code in the Apache source tree, but since you are
only calling it via a <java> call I think we should be ok on that. Correct?
So the primary issue is that it'd be nice to get some input from other JOnAS
users. If we dont, well, we could commit it and then field the feedback
which will come in. Like most optional tasks which arent testable on most
systems its hard to keep these tasks alive without the involvement of the
original author and users.
Before we get that far, there are some bits in the code that, while
workable, are not really what we want in the codebase:
line 160: setVerbose(), 158 setNoGENIC etc.
-use boolean as an argument, not string. Ant will do the conversion for you
and support "yes" and "no" as well as "true" and "false"
line 359: getTask().getProject().copyFile(inSourceJar, inDestJar);
-use FileUtils instead
line 198: setOuputdir, line 216 setWorkDir.
-please be consistent with other tasks which use destDir as the
destination directory. There is now special support for a DestDir datatype
and a setDestDir(DestDir destdir) method, which hands off all the validation
to ant, rather than your task.
lines 294-302
-why are you faffing around with string replacing and searches to find the
parent directory and file name element, why not just use File.getName() and
File.getParent()?
So, why not make the changes, add a junit test class which stresses the task
and start harassing us a week or so into January, when people are back from
their holidays.
-steve
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] ejb-jar/jonas element again
Posted by Peter Donald <pe...@apache.org>.
On Wed, 26 Dec 2001 21:48, Cyrille Morvan wrote:
> Hello again !
>
> I sended my patch two times : a few weeks ago and a few days ago.
>
> I will send my files until they will be commited or a someone gives a good
> reason to not do it !
>
> There is a JBoss version of the DeploymentTool and Ant must have a JOnAS
> version !
The problem is that not many of the Ant committers use EJB and probably none
of them use Jonas. Hopefully Conor (main keeper of the ejb stuff) will have a
look at it once he gets back from holidays. Just remember to keep bugging us
and it will eventually get added in ;)
--
Cheers,
Pete
---------------------------------------------------
"Therefore it can be said that victorious warriors
win first, and then go to battle, while defeated
warriors go to battle first, and then seek to win."
- Sun Tzu, the Art Of War
---------------------------------------------------
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>