You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/31 13:57:40 UTC
[GitHub] [flink] dawidwys opened a new pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
dawidwys opened a new pull request #13287:
URL: https://github.com/apache/flink/pull/13287
## What is the purpose of the change
Removed the ExecutionConfig#get/setCodeAnalysisMode and related classes. We must leave the CodeAnalysisMode enum for now as it is required for java serialization of PojoSerializer.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2557b8aae99f79911f57a6ddbb006038d8ad9f61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #13287:
URL: https://github.com/apache/flink/pull/13287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
}, {
"hash" : "60725808134a5f873d35a5f63dce893194a63238",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019",
"triggerID" : "60725808134a5f873d35a5f63dce893194a63238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2557b8aae99f79911f57a6ddbb006038d8ad9f61 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017)
* 60725808134a5f873d35a5f63dce893194a63238 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
}, {
"hash" : "60725808134a5f873d35a5f63dce893194a63238",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60725808134a5f873d35a5f63dce893194a63238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2557b8aae99f79911f57a6ddbb006038d8ad9f61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017)
* 60725808134a5f873d35a5f63dce893194a63238 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
}, {
"hash" : "60725808134a5f873d35a5f63dce893194a63238",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019",
"triggerID" : "60725808134a5f873d35a5f63dce893194a63238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2557b8aae99f79911f57a6ddbb006038d8ad9f61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017)
* 60725808134a5f873d35a5f63dce893194a63238 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #13287:
URL: https://github.com/apache/flink/pull/13287#discussion_r480160509
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/CodeAnalysisMode.java
##########
@@ -19,21 +19,12 @@
package org.apache.flink.api.common;
import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.java.typeutils.runtime.PojoSerializer;
/**
- * Specifies to which extent user-defined functions are analyzed in order
- * to give the Flink optimizer an insight of UDF internals and inform
- * the user about common implementation mistakes.
- *
- * The analyzer gives hints about:
- * - ForwardedFields semantic properties
- * - Warnings if static fields are modified by a Function
- * - Warnings if a FilterFunction modifies its input objects
- * - Warnings if a Function returns null
- * - Warnings if a tuple access uses a wrong index
- * - Information about the number of object creations (for manual optimization)
- *
* @deprecated The code analysis code has been removed and this enum has no effect.
+ * <b>NOTE</b> It can not be removed from the codebase for now, because it had been serialized as part
+ * of the {@link ExecutionConfig} which in turn had been serialized as part of the {@link PojoSerializer}.
Review comment:
Add a note when exactly we can drop this class. After dropping support for 1.8 savepoints?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2557b8aae99f79911f57a6ddbb006038d8ad9f61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683797382
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2557b8aae99f79911f57a6ddbb006038d8ad9f61 (Mon Aug 31 14:00:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-13857).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13287: [FLINK-13857] Remove deprecated ExecutionConfig#get/setCodeAnalysisMode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13287:
URL: https://github.com/apache/flink/pull/13287#issuecomment-683810669
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6017",
"triggerID" : "2557b8aae99f79911f57a6ddbb006038d8ad9f61",
"triggerType" : "PUSH"
}, {
"hash" : "60725808134a5f873d35a5f63dce893194a63238",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019",
"triggerID" : "60725808134a5f873d35a5f63dce893194a63238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 60725808134a5f873d35a5f63dce893194a63238 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6019)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org