[GitHub] [flink] simplejason commented on a change in pull request #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename

[GitBox <gi...@apache.org>]

simplejason commented on a change in pull request #11731: [FLINK-17130][web] Enable listing JM Logs and displaying Logs by filename
URL: https://github.com/apache/flink/pull/11731#discussion_r408116399
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job-manager/log-detail/job-manager-log-detail.component.less
 ##########
 @@ -16,11 +16,40 @@
  * limitations under the License.
  */
 
+@import "theme";
+
+:host {
+  display: block;
+  height: 100%;
+  &.full-screen {
+    position: fixed;
+    top: 0;
+    bottom: 0;
+    right: 0;
+    left: 0;
+    background: @component-background;
+    z-index: 99;
+    flink-monaco-editor {
+      height: calc(~"100vh - 65px");
+    }
+  }
+}
+
 flink-monaco-editor {
-  height: calc(~"100vh - 160px");
+  height: calc(~"100vh - 220px");
 }
 
-:host {
+.breadcrumb {
+  background: @component-background;
+  border-bottom: 1px solid @border-color-split;
+  margin-bottom: 16px;
+  padding: 12px 24px;
   position: relative;
-  display: block;
+}
+
+flink-refresh-download {
+  position: absolute;
+  right: 12px;
+  top: 0;
+  line-height: 47px;
 
 Review comment:
   We seem to have done some duplicate work with `Task Managers` log list, can we make these codes reusable?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services