You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/02/27 21:45:38 UTC
[3/5] impala git commit: IMPALA-6586: Fix bug in
TestGetTablesTypeTable()
IMPALA-6586: Fix bug in TestGetTablesTypeTable()
The bug in FrontendTest.TestGetTablesTypeTable() was
that it did not explicitly load views that the test
assumed to be loaded already. The test needs to
distinguish between views and tables and views need
to be loaded for them to be discernable from tables.
I was able to reproduce the issue localy by just
running FrontendTest.TestGetTablesTypeTable() without
any other test.
Testing:
- locally ran all tests in FrontendTest individually
(with a fresh ImpaladTestCatalog)
Change-Id: Idf0bddb2e29209adda5bda5ddc428f46f241c8c9
Reviewed-on: http://gerrit.cloudera.org:8080/9453
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/5464c097
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/5464c097
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/5464c097
Branch: refs/heads/master
Commit: 5464c09786b6207507d8ebdbc1f0275f007c08e3
Parents: 83ac412
Author: Alex Behm <al...@cloudera.com>
Authored: Mon Feb 26 12:02:01 2018 -0800
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Tue Feb 27 08:34:36 2018 +0000
----------------------------------------------------------------------
.../org/apache/impala/service/FrontendTest.java | 23 +++++++++++++++-----
1 file changed, 17 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/5464c097/fe/src/test/java/org/apache/impala/service/FrontendTest.java
----------------------------------------------------------------------
diff --git a/fe/src/test/java/org/apache/impala/service/FrontendTest.java b/fe/src/test/java/org/apache/impala/service/FrontendTest.java
index de8b7ac..c7fee57 100644
--- a/fe/src/test/java/org/apache/impala/service/FrontendTest.java
+++ b/fe/src/test/java/org/apache/impala/service/FrontendTest.java
@@ -104,6 +104,12 @@ public class FrontendTest extends FrontendTestBase {
@Test
public void TestGetTablesTypeTable() throws ImpalaException {
+ // Make sure these views are loaded so they can be distinguished from tables.
+ AnalyzesOk("select * from functional.alltypes_hive_view");
+ AnalyzesOk("select * from functional.alltypes_parens");
+ AnalyzesOk("select * from functional.alltypes_view");
+ AnalyzesOk("select * from functional.alltypes_view_sub");
+
TMetadataOpRequest req = new TMetadataOpRequest();
req.opcode = TMetadataOpcode.GET_TABLES;
req.get_tables_req = new TGetTablesReq();
@@ -115,12 +121,13 @@ public class FrontendTest extends FrontendTestBase {
assertEquals(5, resp.schema.columns.size());
assertEquals(5, resp.rows.get(0).colVals.size());
assertEquals(1, resp.rows.size());
- assertEquals("alltypes_datasource", resp.rows.get(0).colVals.get(2).string_val.toLowerCase());
+ assertEquals("alltypes_datasource",
+ resp.rows.get(0).colVals.get(2).string_val.toLowerCase());
}
@Test
public void TestGetTablesTypeView() throws ImpalaException {
- // Issue the statements to make sure all the views are loaded
+ // Make sure these views are loaded so they can be distinguished from tables.
AnalyzesOk("select * from functional.alltypes_hive_view");
AnalyzesOk("select * from functional.alltypes_parens");
AnalyzesOk("select * from functional.alltypes_view");
@@ -137,10 +144,14 @@ public class FrontendTest extends FrontendTestBase {
assertEquals(5, resp.schema.columns.size());
assertEquals(5, resp.rows.get(0).colVals.size());
assertEquals(4, resp.rows.size());
- assertEquals("alltypes_hive_view", resp.rows.get(0).colVals.get(2).string_val.toLowerCase());
- assertEquals("alltypes_parens", resp.rows.get(1).colVals.get(2).string_val.toLowerCase());
- assertEquals("alltypes_view", resp.rows.get(2).colVals.get(2).string_val.toLowerCase());
- assertEquals("alltypes_view_sub", resp.rows.get(3).colVals.get(2).string_val.toLowerCase());
+ assertEquals("alltypes_hive_view",
+ resp.rows.get(0).colVals.get(2).string_val.toLowerCase());
+ assertEquals("alltypes_parens",
+ resp.rows.get(1).colVals.get(2).string_val.toLowerCase());
+ assertEquals("alltypes_view",
+ resp.rows.get(2).colVals.get(2).string_val.toLowerCase());
+ assertEquals("alltypes_view_sub",
+ resp.rows.get(3).colVals.get(2).string_val.toLowerCase());
}
@Test