You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/05 01:21:29 UTC

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1431: feat: support -v command to show version

tokers commented on a change in pull request #1431:
URL: https://github.com/apache/apisix-dashboard/pull/1431#discussion_r570656608



##########
File path: api/cmd/managerapi.go
##########
@@ -135,6 +144,7 @@ func NewManagerAPICommand() *cobra.Command {
 	}
 
 	cmd.PersistentFlags().StringVarP(&conf.WorkDir, "work-dir", "p", ".", "current work directory")
+	cmd.PersistentFlags().BoolVarP(&showVersion, "show_version", "v", false, "show manager api-version")

Review comment:
       I think the long option name just can be "version".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org