[GitHub] [camel-k] lburgazzoli commented on a change in pull request #1274: Refactoring traits to allow addons and add master trait (as addon)

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #1274: Refactoring traits to allow addons and add master trait (as addon)
URL: https://github.com/apache/camel-k/pull/1274#discussion_r379312725
 
 

 ##########
 File path: pkg/trait/trait_types.go
 ##########
 @@ -95,40 +95,49 @@ type Trait interface {
 
 	// RequiresIntegrationPlatform indicates that the trait cannot work without an integration platform set
 	RequiresIntegrationPlatform() bool
+
+	// IsAllowedInProfile tels if the trait supports the given profile
+	IsAllowedInProfile(v1.TraitProfile) bool
+
+	// Order is the order in which the trait should be executed in the normal flow
+	Order() int
 }
 
 /* Base trait */
 
-func newBaseTrait(id string) BaseTrait {
+// NewBaseTrait --
+func NewBaseTrait(id string, order int) BaseTrait {
 
 Review comment:
   Wonder if we should have some constants that could help choosing the right value for the `order` field

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services