You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rodms10 <gi...@git.apache.org> on 2014/04/22 21:19:33 UTC

[GitHub] cordova-cli pull request: [CB-5416] - FirefoxOS - Need to auto gen...

GitHub user rodms10 opened a pull request:

    https://github.com/apache/cordova-cli/pull/168

    [CB-5416] - FirefoxOS - Need to auto generate manifest.webapp with appropriate plugin permissions

    Adds logic to firefoxos_parser to generate manifest permissions based on config.xml. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mozilla-cordova/cordova-cli CB-5416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
    
----
commit 51e82ef840102d28fd4a1e10c2c1b9e027391b4d
Author: Piotr Zalewa <pi...@zalewa.info>
Date:   2014-04-17T18:19:37Z

    Merge pull request #4 from rodms10/autoPermission
    
    CB-5416 - Need to auto generate manifest.webapp with appropriate plugin permissions

commit e87d4f1a113f80e1a5bc60ac2b266e95135c9fa0
Author: Rodrigo Silveira <ro...@outlook.com>
Date:   2014-04-22T16:27:34Z

    Adding support for privileged

commit e4d7fc46680857f5c7784b5379afc2aaa9ebdab5
Author: Rodrigo Silveira <ro...@outlook.com>
Date:   2014-04-22T18:08:06Z

    Check if privileged attribute is 'true'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: [CB-5416] - FirefoxOS - Need to auto gen...

Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:

    https://github.com/apache/cordova-cli/pull/168#issuecomment-41935687
  
    Merged, commits b4febd7c102fcfcb30774d894bab824de9e0bfd3  b454946c26454e74b047d5352c2d490ae3232d54 and 5835a02e877b0b78a30fd0edc989c4b7d93afdd5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: [CB-5416] - FirefoxOS - Need to auto gen...

Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:

    https://github.com/apache/cordova-cli/pull/168#issuecomment-41083008
  
    r+ looks perfectly fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-cli pull request: [CB-5416] - FirefoxOS - Need to auto gen...

Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 closed the pull request at:

    https://github.com/apache/cordova-cli/pull/168


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---