You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/05/20 02:07:24 UTC

[GitHub] [guacamole-client] necouchman commented on pull request #562: GUACAMOLE-641: Expand extension API to allow properties to be retrieved from key vaults.

necouchman commented on pull request #562:
URL: https://github.com/apache/guacamole-client/pull/562#issuecomment-844626701


   > For SystemEnvironmentGuacamoleProperties, the getProperty() implementation will read the current value from System.getenv() each time it's invoked without caching the result. That said, I don't believe it's possible to externally change the environment of a running process without dark magic.
   
   Okay, sounds good. If `getProperty()` calls `getEnv()` each time it runs, are there any performance benefits to caching it, since externally changing the environment requires calling Merlin to conjure up a spell? Or is any performance benefit there outweighed by the amount of code it would take to cache it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org